Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the bytes!() macro #14881

Closed
SimonSapin opened this issue Jun 13, 2014 · 3 comments
Closed

Deprecate the bytes!() macro #14881

SimonSapin opened this issue Jun 13, 2014 · 3 comments

Comments

@SimonSapin
Copy link
Contributor

Depends on #14880. Blocks #14646.

The bytes!() macro is to be removed soon. Using it should cause a compile-time warning the recommends using the new b"foo" byte string literal syntax instead (#14880).

I’d submit a PR (or make it part of #14880), but I don’t know how to do this. Since procedural macros are not defined by a single item, there is nowhere to add #[deprecated]. I suspect there is something to add around here, but any pointer is appreciated.

cc @brson

@alexcrichton
Copy link
Member

You'd probably take a similar route to the old fmt! macro, but use span_warn instead of span_err

@SimonSapin
Copy link
Contributor Author

Actually, do we care about doing this rather than just remove it?

@SimonSapin
Copy link
Contributor Author

Fixed in #15025.

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
internal: Replace Display impl for Name

This allows us to plug in interner for `Name`s that live inside the database.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants