Add byte, byte string, and raw byte string literals. #14880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty awesome, nice work on the tests and documentation! |
|
Pushed some fixup commits that I’d like to squash before this is sent to bors. (Kept separated for now for easier review.) |
| let mut c2 = self_.curr.unwrap_or('\x00'); | ||
| self_.bump(); | ||
|
|
||
| match c2 { |
There was a problem hiding this comment.
This is very very similar to the match for parsing a normal ', could they be factored to share the code? (I think the only real difference is if they accept \u.., \U...?)
|
Looks good to me, thanks! With a rebase I'll r+ |
Move into a new syntax::parse::lexer::StringReader method the code that was almost duplicated for parsing backslash-escapes in byte, byte string, char, and string literals.
|
@alexcrichton Squashed and rebased. |
The change is a result of the char/string parsing refactor.
bors
added a commit
that referenced
this pull request
Jun 18, 2014
See #14646 (tracking issue) and rust-lang/rfcs#69. This does not close the tracking issue, as the `bytes!()` macro still needs to be removed. It will be later, after a snapshot is made with the changes in this PR, so that the new syntax can be used when bootstrapping the compiler.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Remove double lookups from Interned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14646 (tracking issue) and rust-lang/rfcs#69.
This does not close the tracking issue, as the
bytes!()macro still needs to be removed. It will be later, after a snapshot is made with the changes in this PR, so that the new syntax can be used when bootstrapping the compiler.