Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#69325 #69331

Closed
rust-highfive opened this issue Feb 20, 2020 · 1 comment · Fixed by #69344
Closed

miri no longer builds after rust-lang/rust#69325 #69331

rust-highfive opened this issue Feb 20, 2020 · 1 comment · Fixed by #69344
Assignees
@eddyb @RalfJung @oli-obk
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #69325, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 20, 2020
This was referenced Feb 21, 2020
Closed
Merged
bors added a commit to rust-lang/miri that referenced this issue Feb 21, 2020
@bors
Auto merge of #1187 - RalfJung:rustup, r=RalfJung
9e94ab6 
fix for const-prop lint changes

Cc rust-lang/rust#69331
bors added a commit to rust-lang/miri that referenced this issue Feb 21, 2020
@bors
Auto merge of #1187 - RalfJung:rustup, r=RalfJung
5b84620 
fix for const-prop lint changes

Cc rust-lang/rust#69331
@RalfJung RalfJung mentioned this issue Feb 21, 2020
Merged
@RalfJung
Copy link
Member

#69344 takes care of this, but is waiting for review.

@bors bors closed this as completed in 834bc56 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump Miri RalfJung/rust
4 participants
@eddyb @RalfJung @oli-obk @rust-highfive