Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump Miri #69344

Merged
merged 3 commits into from
Feb 24, 2020
Merged

bump Miri #69344

merged 3 commits into from
Feb 24, 2020

Conversation

RalfJung
Copy link
Member

Fixes #69331

r? @ghost Cc @oli-obk

@RalfJung
Copy link
Member Author

@divergentdave with this, some of your PRs are finally being shipped. :)

@RalfJung
Copy link
Member Author

Submodule-only toolstate-fix
@bors r+ p=1

@bors
Copy link
Contributor

bors commented Feb 21, 2020

📌 Commit 821c440 has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 21, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

@bors r-
looks like libstd doesn't come with the debug assertions we expect it to have... odd.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2020
@RalfJung
Copy link
Member Author

All right I think I fixed this, it also needed a change on the Miri side.

r? @oli-obk because bootstrap changes

@RalfJung RalfJung added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2020
@RalfJung RalfJung mentioned this pull request Feb 23, 2020
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Feb 24, 2020

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Feb 24, 2020

📌 Commit ffa1aa6 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2020
@bors
Copy link
Contributor

bors commented Feb 24, 2020

⌛ Testing commit ffa1aa6 with merge 834bc56...

@bors
Copy link
Contributor

bors commented Feb 24, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 834bc56 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 24, 2020
@bors bors merged commit 834bc56 into rust-lang:master Feb 24, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #69344!

Tested on commit 834bc56.
Direct link to PR: #69344

🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 24, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#69344!
b357811 
Tested on commit rust-lang/rust@834bc56.
Direct link to PR: <rust-lang/rust#69344>

🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
@RalfJung RalfJung deleted the miri branch February 26, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#69325
4 participants
@RalfJung @bors @rust-highfive @oli-obk