Tracking Issue for moving UI tests for libstd into unit tests #76268

jyn514 · 2020-09-03T01:11:45Z

This is a tracking issue for switching UI tests in src/test/ui which only test the standard library into unit tests.

Rationale

This will:

Improve compile times for the test suite as a whole, since fewer binaries are being linked and run
Make it easier to find the code corresponding to a failing test
Allow running more tests without having to first build the stage1 compiler
Allow running more tests with miri (https://github.com/RalfJung/miri-test-libstd)

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Mentoring instructions (or rather, suggested workflow for contributors)

Please first leave a comment here stating that you want to work on file xxx.rs or module xxx, to make sure that this implements Sync.

Find a test in src/test/ui that has both // run-pass and a use of the standard library. The test also cannot use //~ WARN or any other error annotations, since that is not supported by #[test]. For more information about annotations see https://rustc-dev-guide.rust-lang.org/tests/adding.html#header_commands; if there is an annotation on the test that can't be replicated with #[test] or #[cfg(...)], feel free to skip it.

rg run-pass src/test/ui -l | xargs rg '(std|alloc|core)::' -l | xargs rg -v 'WARN' -l

Move the test into the relevant part of library/. Add a #[test] annotation so it will be run by x.py test library/std. Make sure that it is actually being run - you can be sure by running x.py test --stage 0 library/std --test-args name_of_the_new_test and seeing at least one test run.

If it is unclear whether run-pass exercises standard library or a particular facet of the compiler, you can look at the PR/commit that introduced the test. If it was introduced together with the stdlib API it exercises, then it definitely belongs to library/. If the test would still work with #![no_core], it's testing the compiler and not the standard library, and shouldn't be moved.

Implementation history

Move some Vec UI tests into alloc unit tests #76273 is a good first example

For other candidates, see, for example, the tests in https://github.com/rust-lang/rust/blob/master/src/test/ui/consts/std/net/ipv6.rs.

Mentoring instructions for reviewers

I highly recommend git show -w --reverse --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change <base>.., where <base> is git merge-base origin/master <tip commit> and <tip commit> is the head of the branch.

@matklad has volunteered to review PRs implementing this. Add r? @matklad to the PR description to automatically assign review to them.

The text was updated successfully, but these errors were encountered:

These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.

Part of rust-lang#76268

Move: - `src\test\ui\consts\const-nonzero.rs` to `library\core` - `src\test\ui\consts\ascii.rs` to `library\core` - `src\test\ui\consts\cow-is-borrowed` to `library\alloc` Part of rust-lang#76268

Move some Vec UI tests into alloc unit tests A bit of work towards rust-lang#76268, makes a number of the Vec UI tests that are simply running code into unit tests. Ensured that they are being run when testing liballoc locally.

Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.

@matklad

Move various ui const tests to `library` Move: - `src\test\ui\consts\const-nonzero.rs` to `library\core` - `src\test\ui\consts\ascii.rs` to `library\core` - `src\test\ui\consts\cow-is-borrowed` to `library\alloc` Part of rust-lang#76268 r? @matklad

Move some Vec UI tests into alloc unit tests A bit of work towards rust-lang#76268, makes a number of the Vec UI tests that are simply running code into unit tests. Ensured that they are being run when testing liballoc locally.

Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.

@matklad

Move various ui const tests to `library` Move: - `src\test\ui\consts\const-nonzero.rs` to `library\core` - `src\test\ui\consts\ascii.rs` to `library\core` - `src\test\ui\consts\cow-is-borrowed` to `library\alloc` Part of rust-lang#76268 r? @matklad

Move some Vec UI tests into alloc unit tests A bit of work towards rust-lang#76268, makes a number of the Vec UI tests that are simply running code into unit tests. Ensured that they are being run when testing liballoc locally.

Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.

@matklad

Move various ui const tests to `library` Move: - `src\test\ui\consts\const-nonzero.rs` to `library\core` - `src\test\ui\consts\ascii.rs` to `library\core` - `src\test\ui\consts\cow-is-borrowed` to `library\alloc` Part of rust-lang#76268 r? @matklad

Move some Vec UI tests into alloc unit tests A bit of work towards rust-lang#76268, makes a number of the Vec UI tests that are simply running code into unit tests. Ensured that they are being run when testing liballoc locally.

Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.

@matklad

Move various ui const tests to `library` Move: - `src\test\ui\consts\const-nonzero.rs` to `library\core` - `src\test\ui\consts\ascii.rs` to `library\core` - `src\test\ui\consts\cow-is-borrowed` to `library\alloc` Part of rust-lang#76268 r? @matklad

Move f64::NAN ui tests into `library` This is a partial fix of rust-lang#76268. r? ```@matklad```

…brary-core, r=jyn514 Move range in ui test to ops test in library/core Helps with rust-lang#76268 r? ````@matklad````

Change ui test that are run-pass and that do not test the compiler to library tests Part of rust-lang#76268, these are some of the relevant ui tests I found that can be replaced by library tests. Note: this PR just moves the tests, I have not checked for any overlap between these tests and existing library tests. The only test I changed is `env_home_dir`, where I added code to restore the old home dir after testing. All moved tests: | ui test | library test file | test | | --- | --- | --- | | `const\ascii_ctype.rs` | `core\tests\ascii.rs` | `ascii_ctype_const` | | `const\const-str-ptr.rs` | `alloc\tests\str.rs` | `const_str_ptr` | | `assert-eq-trailing-comma.rs` | `core\tests\macros.rs` | `assert_eq_trailing_comma` | | `assert-escape.rs` | `core\tests\macros.rs` | `assert_escape` | | `assert-ne-trailing-comma.rs` | `core\tests\macros.rs` | `assert_ne_trailing_comma` | | `atomic-access-bool.rs` | `core\tests\atomic.rs` | `atomic_access_bool` | | `atomic-alignment.rs` | `core\tests\atomic.rs` | `atomic_alignment` | | `atomic-compare_exchange.rs` | `core\tests\atomic.rs` | `atomic_compare_exchange` | | ~~`atomic-print.rs`~~ | ~~`std\tests\process.rs`~~ | ~~`atomic_print`~~ | | `bool.rs` | `core\tests\bool.rs` | `test_bool` | | `bool_not.rs` | `core\tests\bool.rs` | `test_bool_not` | | `char_unicode.rs` | `core\tests\unicode.rs` | `version` | | `cmp-default.rs` | `core\tests\cmp.rs` | `cmp_default` | | `deref-mut-on-ref.rs` | `core\tests\ops.rs` | `deref_mut_on_ref` | | `deref-on-ref.rs` | `core\tests\ops.rs` | `deref_on_ref` | | `env-home-dir.rs` | `std\tests\env.rs` | `env_home_dir` | | ~~`env-vars.rs`~~ | ~~`std\tests\env.rs`~~ | ~~`env_vars`~~ | | `extend-for-unit.rs` | `core\tests\iter.rs` | `extend_for_unit` | | `offset_from.rs` | `core\tests\ptr.rs` | `offset_from` | | `option-ext.rs` | `core\tests\option.rs` | `option_ext` | | `result-opt-conversions.rs` | `core\tests\result.rs` | `result_opt_conversions` | | `sleep.rs` | `std\tests\thread.rs` | `sleep` | | ~~`try-wait.rs`~~ | ~~`std\tests\process.rs`~~ | ~~`try_wait`~~ | | `utf8.rs` | `alloc\tests\str.rs` | `utf8` | | `utf8_chars.rs` | `alloc\tests\str.rs` | `utf8_chars` | | `wrapping-int-api.rs` | `core\tests\num\wrapping.rs` | `wrapping_int_api` |

…-core, r=jyn514 Remove const_fn_feature_flags test ## Overview Helps with rust-lang#76268 I found `const_fn_feature_flags` is targeting feature-gate and remove it. r? `@matklad`

Move const ip in ui test to unit test Helps with rust-lang#76268 r? `@matklad`

Change ui test that are run-pass and that do not test the compiler to library tests Part of rust-lang#76268, these are some of the relevant ui tests I found that can be replaced by library tests. Note: this PR just moves the tests, I have not checked for any overlap between these tests and existing library tests. The only test I changed is `env_home_dir`, where I added code to restore the old home dir after testing. All moved tests: | ui test | library test file | test | | --- | --- | --- | | `const\ascii_ctype.rs` | `core\tests\ascii.rs` | `ascii_ctype_const` | | `const\const-str-ptr.rs` | `alloc\tests\str.rs` | `const_str_ptr` | | `assert-eq-trailing-comma.rs` | `core\tests\macros.rs` | `assert_eq_trailing_comma` | | `assert-escape.rs` | `core\tests\macros.rs` | `assert_escape` | | `assert-ne-trailing-comma.rs` | `core\tests\macros.rs` | `assert_ne_trailing_comma` | | `atomic-access-bool.rs` | `core\tests\atomic.rs` | `atomic_access_bool` | | `atomic-alignment.rs` | `core\tests\atomic.rs` | `atomic_alignment` | | `atomic-compare_exchange.rs` | `core\tests\atomic.rs` | `atomic_compare_exchange` | | ~~`atomic-print.rs`~~ | ~~`std\tests\process.rs`~~ | ~~`atomic_print`~~ | | `bool.rs` | `core\tests\bool.rs` | `test_bool` | | `bool_not.rs` | `core\tests\bool.rs` | `test_bool_not` | | `char_unicode.rs` | `core\tests\unicode.rs` | `version` | | `cmp-default.rs` | `core\tests\cmp.rs` | `cmp_default` | | `deref-mut-on-ref.rs` | `core\tests\ops.rs` | `deref_mut_on_ref` | | `deref-on-ref.rs` | `core\tests\ops.rs` | `deref_on_ref` | | `env-home-dir.rs` | `std\tests\env.rs` | `env_home_dir` | | ~~`env-vars.rs`~~ | ~~`std\tests\env.rs`~~ | ~~`env_vars`~~ | | `extend-for-unit.rs` | `core\tests\iter.rs` | `extend_for_unit` | | `offset_from.rs` | `core\tests\ptr.rs` | `offset_from` | | `option-ext.rs` | `core\tests\option.rs` | `option_ext` | | `result-opt-conversions.rs` | `core\tests\result.rs` | `result_opt_conversions` | | `sleep.rs` | `std\tests\thread.rs` | `sleep` | | ~~`try-wait.rs`~~ | ~~`std\tests\process.rs`~~ | ~~`try_wait`~~ | | `utf8.rs` | `alloc\tests\str.rs` | `utf8` | | `utf8_chars.rs` | `alloc\tests\str.rs` | `utf8_chars` | | `wrapping-int-api.rs` | `core\tests\num\wrapping.rs` | `wrapping_int_api` |

…-core, r=jyn514 Remove const_fn_feature_flags test ## Overview Helps with rust-lang#76268 I found `const_fn_feature_flags` is targeting feature-gate and remove it. r? `@matklad`

Move const ip in ui test to unit test Helps with rust-lang#76268 r? `@matklad`

Change ui test that are run-pass and that do not test the compiler to library tests Part of rust-lang#76268, these are some of the relevant ui tests I found that can be replaced by library tests. Note: this PR just moves the tests, I have not checked for any overlap between these tests and existing library tests. The only test I changed is `env_home_dir`, where I added code to restore the old home dir after testing. All moved tests: | ui test | library test file | test | | --- | --- | --- | | `const\ascii_ctype.rs` | `core\tests\ascii.rs` | `ascii_ctype_const` | | `const\const-str-ptr.rs` | `alloc\tests\str.rs` | `const_str_ptr` | | `assert-eq-trailing-comma.rs` | `core\tests\macros.rs` | `assert_eq_trailing_comma` | | `assert-escape.rs` | `core\tests\macros.rs` | `assert_escape` | | `assert-ne-trailing-comma.rs` | `core\tests\macros.rs` | `assert_ne_trailing_comma` | | `atomic-access-bool.rs` | `core\tests\atomic.rs` | `atomic_access_bool` | | `atomic-alignment.rs` | `core\tests\atomic.rs` | `atomic_alignment` | | `atomic-compare_exchange.rs` | `core\tests\atomic.rs` | `atomic_compare_exchange` | | ~~`atomic-print.rs`~~ | ~~`std\tests\process.rs`~~ | ~~`atomic_print`~~ | | `bool.rs` | `core\tests\bool.rs` | `test_bool` | | `bool_not.rs` | `core\tests\bool.rs` | `test_bool_not` | | `char_unicode.rs` | `core\tests\unicode.rs` | `version` | | `cmp-default.rs` | `core\tests\cmp.rs` | `cmp_default` | | `deref-mut-on-ref.rs` | `core\tests\ops.rs` | `deref_mut_on_ref` | | `deref-on-ref.rs` | `core\tests\ops.rs` | `deref_on_ref` | | `env-home-dir.rs` | `std\tests\env.rs` | `env_home_dir` | | ~~`env-vars.rs`~~ | ~~`std\tests\env.rs`~~ | ~~`env_vars`~~ | | `extend-for-unit.rs` | `core\tests\iter.rs` | `extend_for_unit` | | `offset_from.rs` | `core\tests\ptr.rs` | `offset_from` | | `option-ext.rs` | `core\tests\option.rs` | `option_ext` | | `result-opt-conversions.rs` | `core\tests\result.rs` | `result_opt_conversions` | | `sleep.rs` | `std\tests\thread.rs` | `sleep` | | ~~`try-wait.rs`~~ | ~~`std\tests\process.rs`~~ | ~~`try_wait`~~ | | `utf8.rs` | `alloc\tests\str.rs` | `utf8` | | `utf8_chars.rs` | `alloc\tests\str.rs` | `utf8_chars` | | `wrapping-int-api.rs` | `core\tests\num\wrapping.rs` | `wrapping_int_api` |

…-core, r=jyn514 Remove const_fn_feature_flags test ## Overview Helps with rust-lang#76268 I found `const_fn_feature_flags` is targeting feature-gate and remove it. r? ``@matklad``

Move const ip in ui test to unit test Helps with rust-lang#76268 r? ``@matklad``

GroteGnoom · 2021-01-07T13:39:56Z

@jyn514

#79163 (comment)

@matklad there are probably still some left, but I'm ok with closing the issue and moving the info to the dev-guide, maybe. I think #79038 should be either merged or closed before closing #76268 though.

Since #79038 is merged, should this issue be closed?

jyn514 · 2021-01-07T13:48:12Z

Sounds good to me!

jyn514 · 2021-01-07T13:48:36Z

Thank you everyone who helped fix this!

jyn514 mentioned this issue Sep 3, 2020

feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ rust-lang/highfive#286

Closed

CraftSpider mentioned this issue Sep 3, 2020

Move some Vec UI tests into alloc unit tests #76273

Merged

matklad mentioned this issue Sep 3, 2020

Stabilize Poll::is_ready and is_pending as const #76227

Merged

CDirkx mentioned this issue Sep 3, 2020

Make Ipv4Addr and Ipv6Addr const tests unit tests under library #76299

Merged

CDirkx added a commit to CDirkx/rust that referenced this issue Sep 3, 2020

Make Ipv4Addr and Ipv6Addr const tests unit tests under library

a2e077e

These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.

CDirkx added a commit to CDirkx/rust that referenced this issue Sep 3, 2020

Move const tests for Option to library\core

04e4a39

Part of rust-lang#76268

CDirkx added a commit to CDirkx/rust that referenced this issue Sep 3, 2020

Move const tests for Result to library\core

787b270

Part of rust-lang#76268

CDirkx added a commit to CDirkx/rust that referenced this issue Sep 3, 2020

Move const tests for Ordering to library\core

79d563c

Part of rust-lang#76268

CDirkx mentioned this issue Sep 3, 2020

Make some Ordering methods const #76198

Merged

CDirkx added a commit to CDirkx/rust that referenced this issue Sep 3, 2020

Move const tests for Poll to library\core

ce1d5ed

Part of rust-lang#76268

CDirkx added a commit to CDirkx/rust that referenced this issue Sep 3, 2020

Move const tests for std::path::Prefix to library\core

ba79257

Part of rust-lang#76268

CDirkx mentioned this issue Sep 4, 2020

Move various ui const tests to library #76305

Merged

m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 5, 2020

Rollup merge of rust-lang#78425 - chansuke:move_nan, r=jyn514

9922933

Move f64::NAN ui tests into `library` This is a partial fix of rust-lang#76268. r? ```@matklad```

m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 5, 2020

Rollup merge of rust-lang#78738 - sasurau4:test/move-range-test-to-li…

86e6afa

…brary-core, r=jyn514 Move range in ui test to ops test in library/core Helps with rust-lang#76268 r? ````@matklad````

CDirkx mentioned this issue Nov 14, 2020

Change ui test that are run-pass and that do not test the compiler to library tests #79038

Merged

ayushmishra2005 pushed a commit to ayushmishra2005/rust that referenced this issue Nov 18, 2020

Added tests in int module library as a part of rust-lang#76268

6d88469

ayushmishra2005 mentioned this issue Nov 18, 2020

Added tests in int module library as a part of #76268 #79163

Closed

sasurau4 mentioned this issue Nov 20, 2020

Remove const_fn_feature_flags test #79227

Merged

sasurau4 mentioned this issue Nov 26, 2020

Move const ip in ui test to unit test #79444

Merged

jyn514 mentioned this issue Nov 29, 2020

Move intra-doc link tests into a subdirectory #79527

Merged

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Nov 30, 2020

Rollup merge of rust-lang#79444 - sasurau4:test/move-const-ip, r=matklad

de32e4b

Move const ip in ui test to unit test Helps with rust-lang#76268 r? `@matklad`

jyn514 mentioned this issue Nov 30, 2020

Move uclibc under linux rust-lang/libc#1975

Merged

1 task

m-ou-se added a commit to m-ou-se/rust that referenced this issue Dec 1, 2020

Rollup merge of rust-lang#79444 - sasurau4:test/move-const-ip, r=matklad

fc91eec

Move const ip in ui test to unit test Helps with rust-lang#76268 r? `@matklad`

m-ou-se added a commit to m-ou-se/rust that referenced this issue Dec 1, 2020

Rollup merge of rust-lang#79444 - sasurau4:test/move-const-ip, r=matklad

2404409

Move const ip in ui test to unit test Helps with rust-lang#76268 r? ``@matklad``

jyn514 closed this as completed Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking Issue for moving UI tests for libstd into unit tests #76268

Tracking Issue for moving UI tests for libstd into unit tests #76268

jyn514 commented Sep 3, 2020 •

edited

Loading

Mentoring instructions for reviewers

GroteGnoom commented Jan 7, 2021

jyn514 commented Jan 7, 2021

jyn514 commented Jan 7, 2021

Tracking Issue for moving UI tests for libstd into unit tests #76268

Tracking Issue for moving UI tests for libstd into unit tests #76268

Comments

jyn514 commented Sep 3, 2020 • edited Loading

Rationale

About tracking issues

Mentoring instructions (or rather, suggested workflow for contributors)

Implementation history

Mentoring instructions for reviewers

GroteGnoom commented Jan 7, 2021

jyn514 commented Jan 7, 2021

jyn514 commented Jan 7, 2021

jyn514 commented Sep 3, 2020 •

edited

Loading