Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests in int module library as a part of #76268 #79163

Conversation

ayushmishra2005
Copy link
Contributor

Added Arith Tests library as a part of #76268

r? @matklad

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2020
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Nov 18, 2020
@ayushmishra2005
Copy link
Contributor Author

@matklad @jyn514 please review this pull request

@matklad
Copy link
Member

matklad commented Nov 19, 2020

I think this invokes compiler built-in operations for primitives, rather than going through libcore implementation (rather, ops::Add and friends in libcore are defined in terms of operations on promitives).

So, these tests actually exercise the compiler itself, and not the stdlib, and better be left in place.

@jyn514 I've noticed that a fair share of #76268 PRs now hit this "not actually stdlib" test. This probably means majority of the library tests are now in their proper place and that we can close that issue?

@jyn514
Copy link
Member

jyn514 commented Nov 19, 2020

@matklad there are probably still some left, but I'm ok with closing the issue and moving the info to the dev-guide, maybe. I think #79038 should be either merged or closed before closing #76268 though.

@jyn514
Copy link
Member

jyn514 commented Nov 29, 2020

Closing this since these are testing the compiler and not the standard library.

@jyn514 jyn514 closed this Nov 29, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 29, 2020

As a general rule, if the test would work with #![no_core], it's always a test of the compiler and not the standard library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants