-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #101734
Closed
Closed
Rollup of 7 pull requests #101734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on some poor suggestions produced when stablizing this lint and running it on `manformed-generics.rs`
…sleywiser Fix `ReErased` leaking into typeck due to `typeof(...)` recovery Fixes rust-lang#100183
…=oli-obk constify some `CStr` methods This PR marks the following public APIs as `const`: ```rust impl CStr { // feature(const_cstr_from_bytes) pub const fn from_bytes_until_nul(bytes: &[u8]) -> Result<&CStr, FromBytesUntilNulError>; pub const fn from_bytes_with_nul(bytes: &[u8]) -> Result<&Self, FromBytesWithNulError>; // feature(const_cstr_to_bytes) pub const fn to_bytes(&self) -> &[u8]; pub const fn to_bytes_with_nul(&self) -> &[u8]; pub const fn to_str(&self) -> Result<&str, str::Utf8Error>; } ``` r? ``@oli-obk`` (use of `const_eval_select` :P ) cc ``@mina86`` (you've asked for this <3 )
…stcsession-pt3, r=davidtwco translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Final # Description This is the final part of the rustc_session rust-lang#100717 (comment). Please only review this [commit](rust-lang@a545347). The other ones are from the PR rust-lang#101041 that is not yet merged. In this PR, we migrate the file `output.rs`
…avidtwco A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing Fixes rust-lang#101689
…k, r=oli-obk Allow unauthenticated users to add the `const-hack` label Observed in rust-lang#101401. cc ``@oli-obk``
…html-check, r=GuillaumeGomez rustdoc: improve rustdoc HTML suggestions handling of nested generics Based on some poor suggestions produced when stablizing this lint and running it on `manformed-generics.rs` in rust-lang#101720
rustbot
added
A-translation
Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Sep 12, 2022
@bors r+ p=5 rollup=never |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Sep 12, 2022
@bors r- I think it's #101733 (comment) |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 12, 2022
The job Click to see the possible cause of the failure (guessed by this bot)
|
davidtwco
removed
the
A-translation
Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
label
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ReErased
leaking into typeck due totypeof(...)
recovery #100185 (FixReErased
leaking into typeck due totypeof(...)
recovery)CStr
methods #100291 (constify someCStr
methods)$crate
->$ident:ident
->identity_proc_macro!($ident)
panics in the proc macro #101211)SubstitutionPart
is not considered a deletion if it replaces nothing with nothing #101700 (ASubstitutionPart
is not considered a deletion if it replaces nothing with nothing)const-hack
label #101724 (Allow unauthenticated users to add theconst-hack
label)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup