-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constify slice.split_at_mut(_unchecked) #101800
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Makes public stable method slice::split_at_mut unstably const, so @rustbot label +T-libs-api -T-libs |
Wrong PR title and description? Also you need to use the rebase feature and we do not accept merge commits. https://rustc-dev-guide.rust-lang.org/git.html#rebasing-and-conflicts |
Yes sorry I did the PR's in the wrong order. Changed the title and Description to match and rebased on master so it should be correct now. |
This comment has been minimized.
This comment has been minimized.
r? @fee1-dead |
@bors r+ |
@bors rollup |
…fee1-dead Rollup of 8 pull requests Successful merges: - rust-lang#98111 (Clarify `[T]::select_nth_unstable*` return values) - rust-lang#101431 (Look at move place's type when suggesting mutable reborrow) - rust-lang#101800 (Constify slice.split_at_mut(_unchecked)) - rust-lang#101997 (Remove support for legacy PM) - rust-lang#102194 (Note the type when unable to drop values in compile time) - rust-lang#102200 (Constify Default impl's for Arrays and Tuples.) - rust-lang#102245 (Constify cmp_min_max_by.) - rust-lang#102259 (Type-annotate and simplify documentation of Option::unwrap_or_default) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Tracking Issue: Tracking Issue for const_slice_split_at_mut
Feature gate:
#![feature(const_slice_split_at_mut)]
Still requires const_mut_refs to be actually used, but this feature removes the need to manually re implement these functions in a user crate.