Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify Default impl's for Arrays and Tuples. #102200

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Constify Default impl's for Arrays and Tuples. #102200

merged 1 commit into from
Sep 25, 2022

Conversation

onestacked
Copy link
Contributor

Allows to create arrays and tuples in const Context using the ~const Default implementation of the inner type.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 23, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2022
@onestacked
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 23, 2022
@onestacked
Copy link
Contributor Author

r? @fee1-dead

@rust-highfive rust-highfive assigned fee1-dead and unassigned m-ou-se Sep 25, 2022
@fee1-dead
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 25, 2022

📌 Commit 449326a has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2022
@fee1-dead
Copy link
Member

@bors rollup

@fee1-dead fee1-dead mentioned this pull request Sep 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2022
@bors
Auto merge of rust-lang#102265 - fee1-dead-contrib:rollup-a7fccbg, r=…
17e8752 
…fee1-dead

Rollup of 8 pull requests

Successful merges:

 - rust-lang#98111 (Clarify `[T]::select_nth_unstable*` return values)
 - rust-lang#101431 (Look at move place's type when suggesting mutable reborrow)
 - rust-lang#101800 (Constify slice.split_at_mut(_unchecked))
 - rust-lang#101997 (Remove support for legacy PM)
 - rust-lang#102194 (Note the type when unable to drop values in compile time)
 - rust-lang#102200 (Constify Default impl's for Arrays and Tuples.)
 - rust-lang#102245 (Constify cmp_min_max_by.)
 - rust-lang#102259 (Type-annotate and simplify documentation of Option::unwrap_or_default)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 69aa41b into rust-lang:master Sep 25, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 25, 2022
@leonardo-m
Copy link

leonardo-m commented Sep 29, 2022 •
edited
Loading

There are no tests, so I don't understand how to use this...

Is this pull supposed to allow this?

#![feature(const_default_impls)]
const fn foo() {
    const X: [u32; 10] = Default::default();
    const Y: (u32, u32, u32) = Default::default();
}
fn main() {}

@onestacked
Copy link
Contributor Author

onestacked commented Sep 29, 2022 •
edited
Loading

Yes it does, but
#![feature(const_trait_impl)]
is also required.
playground

@onestacked onestacked deleted the const_default_impls branch November 2, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@onestacked @rustbot @rust-highfive @fee1-dead @bors @leonardo-m @m-ou-se