Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename normalize_opaque_types to reveal_opaque_types_in_bounds #104909

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Rename normalize_opaque_types to reveal_opaque_types_in_bounds #104909

merged 1 commit into from
Nov 26, 2022

Conversation

compiler-errors
Copy link
Member

  1. The query name is a bit misleading, since it doesn't do any associated type normalization, and
  2. since it only takes a predicate list, it sounds a bit more powerful than it actually is.

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2022

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2022
@compiler-errors compiler-errors force-pushed the normalize_opaque_types-is-misleading branch from 6291f35 to 6b63d6c Compare November 25, 2022 19:39
@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 26, 2022

📌 Commit 6b63d6c has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2022
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2022
@bors
Auto merge of rust-lang#104945 - GuillaumeGomez:rollup-ygzbpbe, r=Gui…
80a9646 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104786 (Use the power of adding helper function to simplify code w/ `Mutability`)
 - rust-lang#104788 (Do not record unresolved const vars in generator interior)
 - rust-lang#104909 (Rename `normalize_opaque_types` to `reveal_opaque_types_in_bounds`)
 - rust-lang#104921 (Remove unnecessary binder from `get_impl_future_output_ty`)
 - rust-lang#104924 (jsondoclint: Accept trait alias is places where trait expected.)
 - rust-lang#104928 (rustdoc: use flexbox CSS to align sidebar button instead of position)
 - rust-lang#104943 (jsondoclint: Handle using enum variants and glob using enums.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 75352dd into rust-lang:master Nov 26, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 26, 2022
@compiler-errors compiler-errors deleted the normalize_opaque_types-is-misleading branch November 26, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease left review comments

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @fee1-dead @bors @fmease