Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary binder from get_impl_future_output_ty #104921

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

compiler-errors
Copy link
Member

We never construct an async fn with a higher-ranked impl Future bound anyways, and basically all the call-sites already skip the binder.

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2022
@compiler-errors compiler-errors changed the title Remove unnecessary binder from get_impl_future_output_ty Remove unnecessary binder from get_impl_future_output_ty Nov 26, 2022
@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 26, 2022

📌 Commit 1472b38 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2022
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104786 (Use the power of adding helper function to simplify code w/ `Mutability`)
 - rust-lang#104788 (Do not record unresolved const vars in generator interior)
 - rust-lang#104909 (Rename `normalize_opaque_types` to `reveal_opaque_types_in_bounds`)
 - rust-lang#104921 (Remove unnecessary binder from `get_impl_future_output_ty`)
 - rust-lang#104924 (jsondoclint: Accept trait alias is places where trait expected.)
 - rust-lang#104928 (rustdoc: use flexbox CSS to align sidebar button instead of position)
 - rust-lang#104943 (jsondoclint: Handle using enum variants and glob using enums.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4019c8a into rust-lang:master Nov 26, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 26, 2022
@compiler-errors compiler-errors deleted the no-binder-on-fut-ty branch November 26, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants