Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inferred_outlives_crate return Clause #104911

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Make inferred_outlives_crate return Clause #104911

merged 1 commit into from
Nov 30, 2022

Conversation

spastorino
Copy link
Member

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2022
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 25, 2022
@bors
Copy link
Contributor

bors commented Nov 25, 2022

⌛ Trying commit 7751bbf3d82c5ea82267d541dec2dc20d14abbbe with merge 1cbe4ee0b4070e912c551f82b96cce551e4d6f45...

@spastorino spastorino changed the title [WIP] Make inferred_outlives_crate return Clause Make inferred_outlives_crate return Clause Nov 25, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2022

@rust-timer build 1cbe4ee0b4070e912c551f82b96cce551e4d6f45

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1cbe4ee0b4070e912c551f82b96cce551e4d6f45): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.9% [4.9%, 4.9%] 1
Improvements ✅
(primary)		 -2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)		 -2.5% [-2.7%, -2.3%] 2
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 28, 2022
@spastorino spastorino force-pushed the inferred_outlives_crate-return-clause branch from 7751bbf to 537488e Compare November 29, 2022 15:02
@spastorino
Copy link
Member Author

@oli-obk rebased and addressed the comments you've made and also fixed the iterator issue.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 29, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 29, 2022

📌 Commit 537488e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#104911 - spastorino:inferred_outlives_crate…
de1af83 
…-return-clause, r=oli-obk

Make inferred_outlives_crate return Clause

r? `@oli-obk`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2022
@bors
Auto merge of rust-lang#105070 - matthiaskrgr:rollup-9b25khj, r=matth…
d38a990 
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds)
 - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible)
 - rust-lang#104436 (Add slice to the stack allocated string comment)
 - rust-lang#104523 (Don't use periods in target names)
 - rust-lang#104627 (Print all features with --print target-features)
 - rust-lang#104911 (Make inferred_outlives_crate return Clause)
 - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`)
 - rust-lang#105023 (Statics used in reachable function's inline asm are reachable)
 - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns)
 - rust-lang#105049 (Hermit: Minor build fixes)
 - rust-lang#105051 (Replace a macro with a function)
 - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS)
 - rust-lang#105066 (move `candidate_from_obligation` out of assembly)
 - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.)

Failed merges:

 - rust-lang#105050 (Remove useless borrows and derefs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ca8f4c8 into rust-lang:master Nov 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 30, 2022
@oli-obk oli-obk mentioned this pull request Jan 24, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
6 participants
@spastorino @rust-timer @bors @oli-obk @compiler-errors @rustbot