Rollup of 14 pull requests #105070

matthiaskrgr · 2022-11-29T21:43:23Z

Successful merges:

type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds #103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds)
Explain why rematch_impl fails to be infallible #104427 (Explain why rematch_impl fails to be infallible)
Add slice to the stack allocated string comment #104436 (Add slice to the stack allocated string comment)
Don't use periods in target names #104523 (Don't use periods in target names)
Print all features with --print target-features #104627 (Print all features with --print target-features)
Make inferred_outlives_crate return Clause #104911 (Make inferred_outlives_crate return Clause)
Add PathBuf::as_mut_os_string and Path::as_mut_os_str #105002 (Add PathBuf::as_mut_os_string and Path::as_mut_os_str)
Statics used in reachable function's inline asm are reachable #105023 (Statics used in reachable function's inline asm are reachable)
rustc_ast_{passes,pretty}: remove ref patterns #105045 (rustc_ast_{passes,pretty}: remove ref patterns)
Hermit: Minor build fixes #105049 (Hermit: Minor build fixes)
Replace a macro with a function #105051 (Replace a macro with a function)
rustdoc: use shorthand background for rustdoc toggle CSS #105062 (rustdoc: use shorthand background for rustdoc toggle CSS)
move candidate_from_obligation out of assembly #105066 (move candidate_from_obligation out of assembly)
Run patchelf also on rust-analyzer-proc-macro-srv. #105068 (Run patchelf also on rust-analyzer-proc-macro-srv.)

Failed merges:

Remove useless borrows and derefs #105050 (Remove useless borrows and derefs)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

They can cause issues in e.g. cargo.

…d tied features

… Path` Implements rust-lang/libs-team#140

suggestion from a friend!! 🐸 Co-authored-by: Michael Goulet <[email protected]>

it doesn't belong there as it also does winnowing

type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds fixes rust-lang#103642 rust-lang#102417 only made sure that hidden types cannot outlive lifetimes other than the ones mentioned on bounds, but didn't allow us to actually infer anything from that. cc `@aliemjay`

…ail-actually, r=lcnr Explain why `rematch_impl` fails to be infallible Fixes rust-lang#104395 r? `@lcnr`

…ated-string-comment, r=Mark-Simulacrum Add slice to the stack allocated string comment Precise that the "stack allocated string" is not a string but a string slice. ``@rustbot`` label +A-docs

…leywiser Don't use periods in target names Using a period in the target name can cause issues in e.g. cargo, see also https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Running.20tests.20on.20remote.20target

…s, r=compiler-errors Print all features with --print target-features This fixes `rustc --print target-features` with respect to aliases and tied features. Before this change, the print command assumed that each LLVM feature corresponds exactly to one rustc feature. In the case of aliases and tied features, this assumption failed and some features (such as aarch64's "pacg") were missing. With this change, every target feature is listed.

…-return-clause, r=oli-obk Make inferred_outlives_crate return Clause r? ``@oli-obk``

Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str` Implements rust-lang/libs-team#140 (tracking issue rust-lang#105021).

…r=wesleywiser Statics used in reachable function's inline asm are reachable Fixes rust-lang#104925.

…ler-errors `rustc_ast_{passes,pretty}`: remove `ref` patterns r? `@compiler-errors` Previous PR: rust-lang#104721

Hermit: Minor build fixes These changes are necessary to build for the hermit targets. CC: ``@stlankes``

Replace a macro with a function 🌸

…-background, r=GuillaumeGomez rustdoc: use shorthand background for rustdoc toggle CSS

… r=compiler-errors move `candidate_from_obligation` out of assembly it doesn't belong there as it also does winnowing r? `@compiler-errors`

Run patchelf also on rust-analyzer-proc-macro-srv. On NixOS, `rust-analyzer-proc-macro-srv` needs to be `patchelf`ed just like all the other libs and binaries. With this fix, I am able to use the language server configuration recommended in [the guide](https://rustc-dev-guide.rust-lang.org/building/suggested.html#configuring-rust-analyzer-for-rustc).

matthiaskrgr · 2022-11-29T21:44:00Z

@bors r+ rollup=never p=14

bors · 2022-11-29T21:44:02Z

📌 Commit a5ca67b has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-11-30T00:42:47Z

⌛ Testing commit a5ca67b with merge d38a990...

bors · 2022-11-30T03:45:02Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d38a990 to master...

rust-timer · 2022-11-30T03:48:57Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#105068	8ad5aec193e89922539f8754164171e4f70742d1
#105066	0773c328bed8792c6691bf8ceb04dc2a8e881b5d
#105062	ee6e13f68af47eb2b85844a676c6ec519cfe6aea
#105051	17e4de217f8b27b771ac528e7034eb2b7c3f146a
#105049	e704bea6e80a80fc7a8a24216c29ab5b565a359b
#105045	b7691353d908f1c337e32b74ce1b06c22dc04504
#105023	c9e9633ad8b2c81ef92ca20abc75a1990e2f4cb2
#105002	a6cec30e069d42cd7b3d7ab5249ac037d28b1bb4
#104911	a9bfa8e521ff699ca4a42f2b1e97a091fb1980ae
#104627	00fa443e9d3fa43a651e701d02585f4ad92236f6
#104523	399d2530d33f2178d7a449a40bf774b1e47237e8
#104436	c4ab4b201deb4b443abd86908beb2b04ceb9c32c
#104427	66c54fe3c0b314a5b6ddbfbbfb3f2c4300adfb5a
#103876	29d386e784be2447593ffbf8e4f740ebd71ca2cc

previous master: bddad597fe

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-11-30T07:01:35Z

Finished benchmarking commit (d38a990): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.9%]	7
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	7
Improvements ✅ (primary)	-0.9%	[-1.0%, -0.8%]	2
Improvements ✅ (secondary)	-2.1%	[-2.7%, -1.4%]	8
All ❌✅ (primary)	0.3%	[-1.0%, 0.9%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[0.6%, 3.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.8%, -2.1%]	6
All ❌✅ (primary)	-	-	0

lqd · 2022-11-30T13:17:12Z

The primary regressions on cranelift-codegen and bitmaps are currently noise, so are the wins on keccak. The other secondary regressions could be noise as well, but they're small enough and on stress tests, that it's probably not worth investigating further.

pnkfelix · 2022-12-06T16:03:58Z

I concur with @lqd

@rustbot label: +perf-regression-triaged

flba-eb and others added 30 commits November 17, 2022 10:41

Encourage developers not to use periods in target names

5dd073e

They can cause issues in e.g. cargo.

Remove periods from QNX/nto target names

9c3555d

Print all features with --print target-features, including aliases an…

102a5d8

…d tied features

type annotate &str when stack allocating a string

005c6df

Add more regression tests

ca57832

Add as_mut_os_string to &mut PathBuf and as_mut_os_str to `&mut…

9d66ab0

… Path` Implements rust-lang/libs-team#140

Statics used in reachable function's inline asm are reachable

63915be

rustc_ast_passes: remove ref patterns

07b86a9

rustc_ast_pretty: remove ref patterns

56ae9a1

hermit: Fix fuzzy_provenance_casts

c8f3203

hermit: Remove unused exports

0a4e5ef

Replace a macro with a function

050cee4

Make inferred_outlives_crate return Clause

537488e

rename {max=>largest}_max_leb128_len

8c09515

add FIXME: where it belongs

1b4012e

suggestion from a friend!! 🐸 Co-authored-by: Michael Goulet <[email protected]>

rustdoc: use shorthand background for rustdoc toggle CSS

edf5cce

Explain why rematch_impl fails to be infallible

9512446

move candidate_from_obligation out of assembly

bb982df

it doesn't belong there as it also does winnowing

Run patchelf also on rust-analyzer-proc-macro-srv.

66180df

Rollup merge of rust-lang#104427 - compiler-errors:rematch-impl-may-f…

d88699f

…ail-actually, r=lcnr Explain why `rematch_impl` fails to be infallible Fixes rust-lang#104395 r? `@lcnr`

Rollup merge of rust-lang#104436 - ismailmaj:add-slice-to-stack-alloc…

e4d1fe7

…ated-string-comment, r=Mark-Simulacrum Add slice to the stack allocated string comment Precise that the "stack allocated string" is not a string but a string slice. ``@rustbot`` label +A-docs

Rollup merge of rust-lang#104911 - spastorino:inferred_outlives_crate…

ca8f4c8

…-return-clause, r=oli-obk Make inferred_outlives_crate return Clause r? ``@oli-obk``

Rollup merge of rust-lang#105002 - zertosh:acp-140, r=dtolnay

804fa66

Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str` Implements rust-lang/libs-team#140 (tracking issue rust-lang#105021).

Rollup merge of rust-lang#105023 - tmiasko:asm-sym-static-reachable, …

581ca3e

…r=wesleywiser Statics used in reachable function's inline asm are reachable Fixes rust-lang#104925.

Rollup merge of rust-lang#105045 - WaffleLapkin:deref-ahhhh～, r=compi…

b596d6b

…ler-errors `rustc_ast_{passes,pretty}`: remove `ref` patterns r? `@compiler-errors` Previous PR: rust-lang#104721

Rollup merge of rust-lang#105049 - mkroening:hermit-fixes, r=jyn514

aa674ee

Hermit: Minor build fixes These changes are necessary to build for the hermit targets. CC: ``@stlankes``

Rollup merge of rust-lang#105051 - WaffleLapkin:unmacro, r=oli-obk

776e4a3

Replace a macro with a function 🌸

matthiaskrgr added 3 commits November 29, 2022 22:43

Rollup merge of rust-lang#105062 - notriddle:notriddle/rustdoc-toggle…

5726f1f

…-background, r=GuillaumeGomez rustdoc: use shorthand background for rustdoc toggle CSS

Rollup merge of rust-lang#105066 - lcnr:mv-candidate_from_obligation,…

08a6c93

… r=compiler-errors move `candidate_from_obligation` out of assembly it doesn't belong there as it also does winnowing r? `@compiler-errors`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2022

bors merged commit d38a990 into rust-lang:master Nov 30, 2022

rustbot added this to the 1.67.0 milestone Nov 30, 2022

This was referenced Nov 30, 2022

Implement unification of const abstract impls #104803

Closed

rustc_ast_lowering: Stop lowering imports into multiple items #104963

Merged

Remove useless borrows and derefs #105050

Merged

rustbot added the perf-regression Performance regression. label Nov 30, 2022

rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 6, 2022

matthiaskrgr deleted the rollup-9b25khj branch December 22, 2022 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 14 pull requests #105070

Rollup of 14 pull requests #105070

matthiaskrgr commented Nov 29, 2022

matthiaskrgr commented Nov 29, 2022

bors commented Nov 29, 2022

bors commented Nov 30, 2022

bors commented Nov 30, 2022

rust-timer commented Nov 30, 2022

rust-timer commented Nov 30, 2022

lqd commented Nov 30, 2022

pnkfelix commented Dec 6, 2022

Rollup of 14 pull requests #105070

Rollup of 14 pull requests #105070

Conversation

matthiaskrgr commented Nov 29, 2022

matthiaskrgr commented Nov 29, 2022

bors commented Nov 29, 2022

bors commented Nov 30, 2022

bors commented Nov 30, 2022

rust-timer commented Nov 30, 2022

rust-timer commented Nov 30, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

lqd commented Nov 30, 2022

pnkfelix commented Dec 6, 2022