Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nicer output to PGO build timer #107596

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 2, 2023

This PR modifies the timer used in the PGO build script to contain nicer, hierarchical output of the individual build steps. It's not trivial to test locally, so I'll fire up a dist build right away.

r? @Mark-Simulacrum

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 2, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 2, 2023

@bors try

@bors
Copy link
Contributor

bors commented Feb 2, 2023

⌛ Trying commit 7f9cfce with merge 265c55e4d2aa98b3dee46d23cb6c0b25a7f58d20...

@bors
Copy link
Contributor

bors commented Feb 2, 2023

☀️ Try build successful - checks-actions
Build commit: 265c55e4d2aa98b3dee46d23cb6c0b25a7f58d20 (265c55e4d2aa98b3dee46d23cb6c0b25a7f58d20)

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 2, 2023

☀️ Try build successful - checks-actions
Build commit: 265c55e4d2aa98b3dee46d23cb6c0b25a7f58d20 (265c55e4d2aa98b3dee46d23cb6c0b25a7f58d20)

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 2, 2023

This is how the new format looks like:

Stage 1 (LLVM PGO):            2326.24s (23.29%)
  Build rustc and LLVM:        1729.07s (17.31%)
  Gather profiles:              597.17s ( 5.98%)
Stage 2 (rustc PGO):           1772.25s (17.74%)
  Build rustc and LLVM:         697.05s ( 6.98%)
  Gather profiles:             1075.20s (10.76%)
Stage 3 (LLVM BOLT):           2924.91s (29.28%)
  Build rustc and LLVM:        2102.94s (21.05%)
  Gather profiles:              821.96s ( 8.23%)
Stage 4 (final build):         2966.38s (29.69%)

Total duration:                      2h 46m 30s

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 6, 2023

📌 Commit 7f9cfce has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 6, 2023
…imulacrum

Add nicer output to PGO build timer

This PR modifies the timer used in the PGO build script to contain nicer, hierarchical output of the individual build steps. It's not trivial to test locally, so I'll fire up a dist build right away.

r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#106477 (Refine error spans for "The trait bound `T: Trait` is not satisfied" when passing literal structs/tuples)
 - rust-lang#107596 (Add nicer output to PGO build timer)
 - rust-lang#107692 (Sort Generator `print-type-sizes` according to their yield points)
 - rust-lang#107714 (Clarify wording on f64::round() and f32::round())
 - rust-lang#107720 (end entry paragraph with a period (.))
 - rust-lang#107724 (remove unused rustc_* imports)
 - rust-lang#107725 (Turn MarkdownWithToc into a struct with named fields)
 - rust-lang#107731 (interpret: move discriminant reading and writing to separate file)
 - rust-lang#107735 (Add mailmap for commits made by [email protected])

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 64db7fb into rust-lang:master Feb 6, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 6, 2023
@Kobzol Kobzol deleted the stage-build-timer branch February 7, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants