Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use itertools::Either instead of own impl #110182

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Use itertools::Either instead of own impl #110182

merged 2 commits into from
Apr 12, 2023

Conversation

WaffleLapkin
Copy link
Member

Yeah.

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2023
@rustbot

This comment was marked as resolved.

Sign in to view
@Noratrieb
Copy link
Member

r? Nilstrieb
itertools is probably somewhere in the dep tree already, so that sounds great

@rustbot rustbot assigned Noratrieb and unassigned compiler-errors Apr 11, 2023
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2023

📌 Commit a329592 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2023
@WaffleLapkin
Copy link
Member Author

itertools is indeed in the dep tree (in multiple crate's deps, actually!), checked before doing this :)

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 11, 2023
@compiler-errors
Rollup merge of rust-lang#110182 - WaffleLapkin:neither, r=Nilstrieb
ad17c3d 
Use `itertools::Either` instead of own impl

Yeah.
@compiler-errors compiler-errors mentioned this pull request Apr 11, 2023
Closed
@cuviper
Copy link
Member

cuviper commented Apr 11, 2023

FWIW, itertools::Either is re-export of either::Either, so you could shorten that dependency chain slightly.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 12, 2023
@compiler-errors
Rollup merge of rust-lang#110182 - WaffleLapkin:neither, r=Nilstrieb
ffd0aeb 
Use `itertools::Either` instead of own impl

Yeah.
@compiler-errors compiler-errors mentioned this pull request Apr 12, 2023
Closed
@WaffleLapkin
Copy link
Member Author

@cuviper I don't think it matters, given that we need itertools for other crates anyway, but good to know.

@matthiaskrgr matthiaskrgr mentioned this pull request Apr 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2023
@bors
Auto merge of rust-lang#110239 - matthiaskrgr:rollup-o90hx4s, r=matth…
59a05ad 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#109959 (Fix transmute intrinsic mir validation ICE)
 - rust-lang#110176 (Renumbering cleanups)
 - rust-lang#110182 (Use `itertools::Either` instead of own impl)
 - rust-lang#110188 (Remove orphaned remove_dir_all implementation from rust-installer)
 - rust-lang#110190 (Custom MIR: Support `BinOp::Offset`)
 - rust-lang#110209 (Add regression test for rust-lang#59003)
 - rust-lang#110210 (`DescriptionCtx` cleanups)
 - rust-lang#110217 (doc: loongarch: Fix typos)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f21d840 into rust-lang:master Apr 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 12, 2023
@WaffleLapkin WaffleLapkin deleted the neither branch April 14, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
6 participants
@WaffleLapkin @rustbot @Noratrieb @bors @cuviper @compiler-errors