Rollup of 8 pull requests #110239
Merged
Rollup of 8 pull requests #110239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has a single callsite.
I have no idea why it's here, but it's not used at all.
Signed-off-by: Yuki Okushi <[email protected]>
It's a more descriptive name.
It has a single callsite.
It has a single call site, and the code is clearer with all region kinds handled in one function, instead of splitting the handling across two functions. The commit also changes `DescriptionCtx::new` to use a more declarative style, instead of creating a default `DescriptionCtx` and modifying it, which I find easier to read.
For similar reasons to the previous commit.
…ompiler-errors Fix transmute intrinsic mir validation ICE I stumbled across this at work, the minimal reproducer is included as a test which ICEs before this change. I'm not 100% sure this is the right fix, but it matches what we do in `mir_assign_valid_types` so seems reasonable at least. fixes rust-lang#110151 r? `@lcnr` since they've been keeping the relevant logic correct, cc `@scottmcm`
Renumbering cleanups r? ``@lqd``
Use `itertools::Either` instead of own impl Yeah.
…=jyn514 Remove orphaned remove_dir_all implementation from rust-installer I have no idea why it's here, but it's not used at all. r? Mark-Simulacrum
Custom MIR: Support `BinOp::Offset` Since offset doesn't have an infix operator, a new function `Offset` is added which is lowered to `Rvalue::BinaryOp(BinOp::Offset, ..)` r? ```@oli-obk``` or ```@tmiasko``` or ```@JakobDegen```
…errors Add regression test for rust-lang#59003 Closes rust-lang#59003 r? compiler-errors
…s, r=davidtwco `DescriptionCtx` cleanups Best reviewed one commit at a time. r? `@davidtwco`
…umeGomez doc: loongarch: Fix typos
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=8 |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 661b33f524 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (59a05ad): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
itertools::Eitherinstead of own impl #110182 (Useitertools::Eitherinstead of own impl)BinOp::Offset#110190 (Custom MIR: SupportBinOp::Offset)DescriptionCtxcleanups #110210 (DescriptionCtxcleanups)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup