Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntactically accept become expressions (explicit tail calls experiment) #112790

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Syntactically accept become expressions (explicit tail calls experiment) #112790

merged 3 commits into from
Jun 21, 2023

Conversation

WaffleLapkin
Copy link
Member

This adds ast::ExprKind::Become, implements parsing and properly gates the feature.

cc @scottmcm

@WaffleLapkin WaffleLapkin added the F-explicit_tail_calls `#![feature(explicit_tail_calls)]` label Jun 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 19, 2023
@WaffleLapkin WaffleLapkin mentioned this pull request Jun 19, 2023
Open
6 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Noratrieb
Noratrieb approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? Nilstrieb
r=me on the compiler changes, but I see clippy is failing

@rustbot rustbot assigned Noratrieb and unassigned jackh726 Jun 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 19, 2023
@WaffleLapkin WaffleLapkin removed the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 19, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the syntactically branch 2 times, most recently from dd1ec00 to f01f474 Compare June 19, 2023 12:23
Noratrieb
Noratrieb reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if CI is green

@WaffleLapkin
Copy link
Member Author

Right, the span bug fires on the test >_>

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Noratrieb
Copy link
Member

probably better to just leave it out then, i dont think it matters much

@WaffleLapkin
Copy link
Member Author

@bors r=Nilstrieb

@bors
Copy link
Contributor

bors commented Jun 19, 2023

📌 Commit b967f5c has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2023
@Noratrieb Noratrieb mentioned this pull request Jun 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2023
@bors
Auto merge of rust-lang#112877 - Nilstrieb:rollup-5g5hegl, r=Nilstrieb
97bf23d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#112632 (Implement PartialOrd for `Vec`s over different allocators)
 - rust-lang#112759 (Make closure_saved_names_of_captured_variables a query. )
 - rust-lang#112772 (Add a fully fledged `Clause` type, rename old `Clause` to `ClauseKind`)
 - rust-lang#112790 (Syntactically accept `become` expressions (explicit tail calls experiment))
 - rust-lang#112830 (More codegen cleanups)
 - rust-lang#112844 (Add retag in MIR transform: `Adt` for `Unique` may contain a reference)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c6710d1 into rust-lang:master Jun 21, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 21, 2023
@WaffleLapkin WaffleLapkin deleted the syntactically branch June 21, 2023 10:57
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2023
@Noratrieb
Rollup merge of rust-lang#112790 - WaffleLapkin:syntactically, r=Nils…
0c94826 
…trieb

Syntactically accept `become` expressions (explicit tail calls experiment)

This adds `ast::ExprKind::Become`, implements parsing and properly gates the feature.

cc `@scottmcm`
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2023
@bors
Auto merge of rust-lang#112877 - Nilstrieb:rollup-5g5hegl, r=Nilstrieb
a2b99d8 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#112632 (Implement PartialOrd for `Vec`s over different allocators)
 - rust-lang#112759 (Make closure_saved_names_of_captured_variables a query. )
 - rust-lang#112772 (Add a fully fledged `Clause` type, rename old `Clause` to `ClauseKind`)
 - rust-lang#112790 (Syntactically accept `become` expressions (explicit tail calls experiment))
 - rust-lang#112830 (More codegen cleanups)
 - rust-lang#112844 (Add retag in MIR transform: `Adt` for `Unique` may contain a reference)

r? `@ghost`
`@rustbot` modify labels: rollup
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Oct 23, 2023
@Noratrieb
Rollup merge of rust-lang#112790 - WaffleLapkin:syntactically, r=Nils…
80bf3ea 
…trieb

Syntactically accept `become` expressions (explicit tail calls experiment)

This adds `ast::ExprKind::Become`, implements parsing and properly gates the feature.

cc `@scottmcm`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
F-explicit_tail_calls `#![feature(explicit_tail_calls)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
7 participants
@WaffleLapkin @rustbot @rust-log-analyzer @Noratrieb @bors @bjorn3 @jackh726