Allow escaping bound vars during normalize_erasing_regions in new solver

[compiler-errors]

Add AllowEscapingBoundVars to deeply_normalize, and use it in the new solver in the query_normalize routine.

Ideally, we'd make all query_normalize calls handle pass in AllowEscapingBoundVars individually, because really the only query_normalize call that needs AllowEscapingBoundVars::Yes is the one in try_normalize_generic_arg_after_erasing_regions, but I think that's kind of overkill. I am happy to be convinced otherwise, though.

r? @lcnr

[rustbot]

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

[lcnr]

this feels a bit meh as AllowEscapingBoundVars should really be contained to fn query_normalize I think, would the following work:

• add deeply_normalize_with_skipped_universes which takes a Vec<Option<UniverseIndex>> as argument.
• rework fn query_normalize to first compute the skipped universes and then either use them as args to deeply_normalize or for the QueryNormalizer

[compiler-errors]

Yeah that works.

[lcnr]

@bors try @rust-timer queue

r=me after perf is green, iirc query_normalize is somewhat hot and moving this check might somehow hurt us?

[bors]

⌛ Trying commit 7cb69bac0cc10833ef65e41c3eaafdff9d6653c4 with merge a7f5f14571289eb2d96c1311ba51e7c30f11a1b7...

[bors]

☀️ Try build successful - checks-actions
Build commit: a7f5f14571289eb2d96c1311ba51e7c30f11a1b7 (a7f5f14571289eb2d96c1311ba51e7c30f11a1b7)

[rust-timer]

Finished benchmarking commit (a7f5f14571289eb2d96c1311ba51e7c30f11a1b7): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.307s -> 657.607s (-0.11%)

[compiler-errors]

@bors r=lcnr

[bors]

📌 Commit 1ef85d8 has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1ef85d8 with merge ad96323...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing ad96323 to master...

[rust-timer]

Finished benchmarking commit (ad96323): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[3.7%, 6.5%]	2
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.477s -> 657.64s (-0.13%)