-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace switch to unreachable by assume statements #113970
Conversation
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 0657bc785d7ffb2c86cf1fce7f7cc0744d5e52ae with merge ad0888358a489103ed6806cffede10c65252400d... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (ad0888358a489103ed6806cffede10c65252400d): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 651.047s -> 650.252s (-0.12%) |
Perf : small improvements and regressions balance out. |
r? compiler |
0657bc7
to
930edfa
Compare
r? compiler |
r? compiler |
930edfa
to
aa7e5ca
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #116569) made this pull request unmergeable. Please resolve the merge conflicts. |
9ad64b9
to
631ce68
Compare
The tests failed repeatedly. At this point, I have not found a cause, but I cannot rule out this PR causes them. |
631ce68
to
ae2e211
Compare
Rebased. Let's see if the failure is gone. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (98f5ebb): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 638.855s -> 636.96s (-0.30%) |
78: Automated pull from upstream `master` r=tshepang a=github-actions[bot] This PR pulls the following changes from the upstream repository: * rust-lang/rust#113970 * rust-lang/rust#117459 * rust-lang/rust#117451 * rust-lang/rust#117439 * rust-lang/rust#117417 * rust-lang/rust#117388 * rust-lang/rust#113241 * rust-lang/rust#117462 * rust-lang/rust#117450 * rust-lang/rust#117407 * rust-lang/rust#117444 * rust-lang/rust#117438 * rust-lang/rust#117421 * rust-lang/rust#117416 * rust-lang/rust#116712 * rust-lang/rust#116267 * rust-lang/rust#117377 * rust-lang/rust#117419 Co-authored-by: Alexis (Poliorcetics) Bourget <[email protected]> Co-authored-by: Esteban Küber <[email protected]> Co-authored-by: David Tolnay <[email protected]> Co-authored-by: Celina G. Val <[email protected]> Co-authored-by: Michael Goulet <[email protected]> Co-authored-by: bors <[email protected]> Co-authored-by: Camille GILLOT <[email protected]> Co-authored-by: lcnr <[email protected]> Co-authored-by: Zalathar <[email protected]> Co-authored-by: Oli Scherer <[email protected]>
UnreachablePropagation
currently keeps some switch terminators alive in order to ensure codegen can infer the inequalities on the discriminants.This PR proposes to encode those inequalities as
Assume
statements.This allows to simplify MIR further by removing some useless terminators.