-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style-guide: don't flatten match arms with macro call #114154
Conversation
Some changes occurred in src/doc/style-guide cc @rust-lang/style |
This seems like the best available alternative, and accurately describes current behavior. Also, this is preserving a rule that was already in the style guide and had gotten lost in the transition. I think we should try to do better in future style editions. But for now: @bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (37343f4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 653.498s -> 652.048s (-0.22%) |
This pulls forward the gist of the text that was added to the style guide in rust-lang/style-team#159 to account for needing to tweak/soften rustfmt's behavior based on the style guide prescriptions.
There were a few options I considered, noted below, and although I don't particularly love any of them, I felt this was the lesser of the evils.
r? @joshtriplett