Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style-guide: don't flatten match arms with macro call #114154

Merged
merged 1 commit into from
Jul 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/doc/style-guide/src/expressions.md
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,8 @@ never use a block (unless the block is empty).

If the right-hand side consists of multiple statements, or has line comments,
or the start of the line does not fit on the same line as the left-hand side,
joshtriplett marked this conversation as resolved.
Show resolved Hide resolved
use a block.
use a block. Do not flatten a right-hand side block containing a single macro call
because its expanded form could contain a trailing semicolon.
joshtriplett marked this conversation as resolved.
Show resolved Hide resolved
joshtriplett marked this conversation as resolved.
Show resolved Hide resolved

Block-indent the body of a block arm.

Expand All @@ -686,6 +687,10 @@ match foo {
bar => {}
// Trailing comma on last item.
foo => bar,
baz => qux!(),
lorem => {
ipsum!()
}
}
```

Expand Down