Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style-guide: Add guidance for defining formatting for specific macros #114919

Merged
merged 1 commit into from
Aug 28, 2023
Merged

style-guide: Add guidance for defining formatting for specific macros #114919

merged 1 commit into from
Aug 28, 2023

Conversation

joshtriplett
Copy link
Member

No description provided.

@joshtriplett joshtriplett added the T-style Relevant to the style team, which will review and decide on the PR/issue. label Aug 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2023

r? @calebcartwright

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2023

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

@joshtriplett
Copy link
Member Author

Let's make sure we have consensus on this as a policy.

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Aug 17, 2023 •
edited by calebcartwright
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 17, 2023
@rfcbot
Copy link

rfcbot commented Aug 17, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

calebcartwright
calebcartwright reviewed Aug 19, 2023
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be good with this as is, but one inline question below

src/doc/style-guide/src/expressions.md Show resolved Hide resolved
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 27, 2023
@rfcbot
Copy link

rfcbot commented Aug 27, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@calebcartwright
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 27, 2023

📌 Commit 69f38f6 has been approved by calebcartwright

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 27, 2023
@GuillaumeGomez
Rollup merge of rust-lang#114919 - joshtriplett:style-guide-macros, r…
9d64b0a 
…=calebcartwright

style-guide: Add guidance for defining formatting for specific macros
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 27, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2023
@bors
Auto merge of rust-lang#115303 - matthiaskrgr:rollup-iohs8a5, r=matth…
7e02fd8 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#109660 (Document that SystemTime does not count leap seconds)
 - rust-lang#114238 (Fix implementation of `Duration::checked_div`)
 - rust-lang#114512 (std/tests: disable ancillary tests on freebsd since the feature itsel…)
 - rust-lang#114919 (style-guide: Add guidance for defining formatting for specific macros)
 - rust-lang#115278 (tell people what to do when removing an error code)
 - rust-lang#115280 (avoid triple-backtrace due to panic-during-cleanup)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8140856 into rust-lang:master Aug 28, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 28, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright left review comments

Assignees

@calebcartwright calebcartwright

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-style Relevant to the style team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@joshtriplett @rustbot @rfcbot @calebcartwright @bors @apiraino