tell people what to do when removing an error code #115278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in diagnostic error codes |
This was referenced Aug 27, 2023
RalfJung
force-pushed
the
removed-error-codes
branch
from
cb977e4 to
776466d
Compare
GuillaumeGomez
approved these changes
Aug 27, 2023
|
This is a very good idea! @bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 27, 2023
…illaumeGomez tell people what to do when removing an error code Currently tidy and CI send developers on a wild goose chase: - you edit the code - CI/tidy tells you that an error code is gone, so you remove it from the list - CI/tidy tells you that the markdown file is stale, so you remove that as well - CI (but not tidy) tells you not to remove an error description and copy what E0001 does Let's be nice to people and directly tell them what to do rather than making them follow misleading breadcrumbs. r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 28, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#109660 (Document that SystemTime does not count leap seconds) - rust-lang#114238 (Fix implementation of `Duration::checked_div`) - rust-lang#114512 (std/tests: disable ancillary tests on freebsd since the feature itsel…) - rust-lang#114919 (style-guide: Add guidance for defining formatting for specific macros) - rust-lang#115278 (tell people what to do when removing an error code) - rust-lang#115280 (avoid triple-backtrace due to panic-during-cleanup) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tidy and CI send developers on a wild goose chase:
Let's be nice to people and directly tell them what to do rather than making them follow misleading breadcrumbs.
r? @GuillaumeGomez