-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat StatementKind::Coverage
as completely opaque for SMIR purposes
#115093
Conversation
Coverage statements in MIR are heavily tied to internal details of the coverage implementation that are likely to change, and are unlikely to be useful to third-party tools for the foreseeable future.
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino |
For context, I noticed that #114320 added SMIR copies of various MIR data structures used by I asked about this on Zulip, and people seemed favourable to treating |
r=me with ok from SMIR team. |
@bors r=cjgillot,oli-obk |
⌛ Testing commit 1fac8a0 with merge b1782d7be6aa05870ba1771b3d7d675a45b86dab... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry |
⌛ Testing commit 1fac8a0 with merge a84572b85fd6afa8d9bd8a686e7d70f7f2a28fe4... |
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
I assume this is spurious failure due to rust-lang/homu#75 ? |
@bors retry |
Finished benchmarking commit (a84572b85fd6afa8d9bd8a686e7d70f7f2a28fe4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.241s -> 631.642s (0.06%) |
@bors retry 422 Update is not a fast forward |
@bors r=cjgillot,oli-obk |
💡 This pull request was already approved, no need to approve it again.
|
☀️ Test successful - checks-actions |
Finished benchmarking commit (738df13): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.944s -> 630.96s (-0.16%) |
Coverage statements in MIR are heavily tied to internal details of the coverage implementation that are likely to change, and are unlikely to be useful to third-party tools for the foreseeable future.