Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat StatementKind::Coverage as completely opaque for SMIR purposes #115093

Merged
merged 1 commit into from
Aug 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 1 addition & 55 deletions compiler/rustc_smir/src/rustc_smir/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ use crate::stable_mir::ty::{
};
use crate::stable_mir::{self, Context};
use rustc_hir as hir;
use rustc_middle::mir::coverage::CodeRegion;
use rustc_middle::mir::interpret::alloc_range;
use rustc_middle::mir::{self, ConstantKind};
use rustc_middle::ty::{self, Ty, TyCtxt, Variance};
Expand Down Expand Up @@ -168,10 +167,7 @@ impl<'tcx> Stable<'tcx> for mir::Statement<'tcx> {
variance: variance.stable(tables),
}
}
Coverage(coverage) => stable_mir::mir::Statement::Coverage(stable_mir::mir::Coverage {
kind: coverage.kind.stable(tables),
code_region: coverage.code_region.as_ref().map(|reg| reg.stable(tables)),
}),
Coverage(coverage) => stable_mir::mir::Statement::Coverage(opaque(coverage)),
Intrinsic(intrinstic) => {
stable_mir::mir::Statement::Intrinsic(intrinstic.stable(tables))
}
Expand Down Expand Up @@ -472,30 +468,6 @@ impl<'tcx> Stable<'tcx> for mir::Place<'tcx> {
}
}

impl<'tcx> Stable<'tcx> for mir::coverage::CoverageKind {
type T = stable_mir::mir::CoverageKind;
fn stable(&self, tables: &mut Tables<'tcx>) -> Self::T {
use rustc_middle::mir::coverage::CoverageKind;
match self {
CoverageKind::Counter { function_source_hash, id } => {
stable_mir::mir::CoverageKind::Counter {
function_source_hash: *function_source_hash as usize,
id: opaque(id),
}
}
CoverageKind::Expression { id, lhs, op, rhs } => {
stable_mir::mir::CoverageKind::Expression {
id: opaque(id),
lhs: opaque(lhs),
op: op.stable(tables),
rhs: opaque(rhs),
}
}
CoverageKind::Unreachable => stable_mir::mir::CoverageKind::Unreachable,
}
}
}

impl<'tcx> Stable<'tcx> for mir::UserTypeProjection {
type T = stable_mir::mir::UserTypeProjection;

Expand All @@ -504,18 +476,6 @@ impl<'tcx> Stable<'tcx> for mir::UserTypeProjection {
}
}

impl<'tcx> Stable<'tcx> for mir::coverage::Op {
type T = stable_mir::mir::Op;

fn stable(&self, _: &mut Tables<'tcx>) -> Self::T {
use rustc_middle::mir::coverage::Op::*;
match self {
Subtract => stable_mir::mir::Op::Subtract,
Add => stable_mir::mir::Op::Add,
}
}
}

impl<'tcx> Stable<'tcx> for mir::Local {
type T = stable_mir::mir::Local;
fn stable(&self, _: &mut Tables<'tcx>) -> Self::T {
Expand Down Expand Up @@ -562,20 +522,6 @@ impl<'tcx> Stable<'tcx> for ty::UserTypeAnnotationIndex {
}
}

impl<'tcx> Stable<'tcx> for CodeRegion {
type T = stable_mir::mir::CodeRegion;

fn stable(&self, _: &mut Tables<'tcx>) -> Self::T {
stable_mir::mir::CodeRegion {
file_name: self.file_name.as_str().to_string(),
start_line: self.start_line as usize,
start_col: self.start_col as usize,
end_line: self.end_line as usize,
end_col: self.end_col as usize,
}
}
}

impl<'tcx> Stable<'tcx> for mir::UnwindAction {
type T = stable_mir::mir::UnwindAction;
fn stable(&self, _: &mut Tables<'tcx>) -> Self::T {
Expand Down
43 changes: 4 additions & 39 deletions compiler/rustc_smir/src/stable_mir/mir/body.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,10 @@ pub enum AsyncGeneratorKind {
}

pub(crate) type LocalDefId = Opaque;
pub(crate) type CounterValueReference = Opaque;
pub(crate) type InjectedExpressionId = Opaque;
pub(crate) type ExpressionOperandId = Opaque;
/// [`rustc_middle::mir::Coverage`] is heavily tied to internal details of the
/// coverage implementation that are likely to change, and are unlikely to be
/// useful to third-party tools for the foreseeable future.
pub(crate) type Coverage = Opaque;

/// The FakeReadCause describes the type of pattern why a FakeRead statement exists.
#[derive(Clone, Debug)]
Expand Down Expand Up @@ -166,42 +167,6 @@ pub enum Variance {
Bivariant,
}

#[derive(Clone, Debug)]
pub enum Op {
Subtract,
Add,
}

#[derive(Clone, Debug)]
pub enum CoverageKind {
Counter {
function_source_hash: usize,
id: CounterValueReference,
},
Expression {
id: InjectedExpressionId,
lhs: ExpressionOperandId,
op: Op,
rhs: ExpressionOperandId,
},
Unreachable,
}

#[derive(Clone, Debug)]
pub struct CodeRegion {
pub file_name: String,
pub start_line: usize,
pub start_col: usize,
pub end_line: usize,
pub end_col: usize,
}

#[derive(Clone, Debug)]
pub struct Coverage {
pub kind: CoverageKind,
pub code_region: Option<CodeRegion>,
}

#[derive(Clone, Debug)]
pub struct CopyNonOverlapping {
pub src: Operand,
Expand Down