MIR validation: reject in-place argument/return for packed fields #115164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
RalfJung
force-pushed
the
no-in-place-packed
branch
from
36e3782 to
c3dd437
Compare
RalfJung
commented
Aug 24, 2023
| let mut has_duplicates = false; | ||
| for arg in args { | ||
| if let Operand::Move(place) = arg { | ||
| has_duplicates |= !self.place_cache.insert(place.as_ref()); | ||
| if is_within_packed(self.tcx, &self.body.local_decls, *place).is_some() { |
There was a problem hiding this comment.
@cjgillot right now this is more strict than your check in #115138. Your pass might introduce move of packed fields if the field happens to not require more alignment anyway (such as a u8 in a packed struct). However determining that requires a param_env and then I'd have to move this check into the TypeChecker... is it really worth allowing such moves?
There was a problem hiding this comment.
My patch uses is_disaligned for simplicity. No objection to using is_with_packed: as simple and more secure.
RalfJung
force-pushed
the
no-in-place-packed
branch
from
c3dd437 to
739144f
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 28, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115164 (MIR validation: reject in-place argument/return for packed fields) - rust-lang#115240 (codegen_llvm/llvm_type: avoid matching on the Rust type) - rust-lang#115294 (More precisely detect cycle errors from type_of on opaque) - rust-lang#115310 (Document panic behavior across editions, and improve xrefs) - rust-lang#115311 (Revert "Suggest using `Arc` on `!Send`/`!Sync` types") - rust-lang#115317 (Devacationize oli-obk) - rust-lang#115319 (don't use SnapshotVec in Graph implementation, as it looks unused; use Vec instead) - rust-lang#115322 (Tweak output of `to_pretty_impl_header` involving only anon lifetimes) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here.