Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest iter_mut() where trying to modify elements from .iter() #115308

Merged
merged 1 commit into from
Sep 11, 2023
Merged

suggest iter_mut() where trying to modify elements from .iter() #115308

merged 1 commit into from
Sep 11, 2023

Conversation

chenyukang
Copy link
Member

Fixes #115259
Fixes #62387

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 28, 2023
@chenyukang chenyukang force-pushed the yukang-fix-62387-iter-mut branch from 2863815 to 982e5ae Compare August 28, 2023 09:08
davidtwco
davidtwco requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, left a few comments.

compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated Show resolved Hide resolved
compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated Show resolved Hide resolved
compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated Show resolved Hide resolved
tests/ui/borrowck/issue-62387-suggest-iter-mut.rs Outdated Show resolved Hide resolved
@chenyukang chenyukang force-pushed the yukang-fix-62387-iter-mut branch 6 times, most recently from 61e77d6 to 4f9dcc9 Compare August 29, 2023 15:12
@chenyukang
Copy link
Member Author

@rustbot ready

davidtwco
davidtwco approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small nits

compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated Show resolved Hide resolved
compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated Show resolved Hide resolved
@chenyukang chenyukang force-pushed the yukang-fix-62387-iter-mut branch from 4f9dcc9 to 3050e3b Compare September 6, 2023 16:02
@chenyukang chenyukang force-pushed the yukang-fix-62387-iter-mut branch from 3050e3b to 3988ff2 Compare September 6, 2023 16:29
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 11, 2023

📌 Commit 3988ff2 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2023
@bors
Copy link
Contributor

bors commented Sep 11, 2023

⌛ Testing commit 3988ff2 with merge 68c2f5b...

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 11, 2023
@Dylan-DPC
Rollup merge of rust-lang#115308 - chenyukang:yukang-fix-62387-iter-m…
93464a1 
…ut, r=davidtwco

suggest iter_mut() where trying to modify elements from .iter()

Fixes rust-lang#115259
Fixes rust-lang#62387
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 11, 2023
Closed
@bors
Copy link
Contributor

bors commented Sep 11, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 68c2f5b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2023
@bors bors merged commit 68c2f5b into rust-lang:master Sep 11, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 11, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2023
@bors
Auto merge of rust-lang#115755 - Dylan-DPC:rollup-4sz8hpu, r=Dylan-DPC
fbaae6f 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#115308 (suggest iter_mut() where trying to modify elements from .iter())
 - rust-lang#115595 (Fix incorrect mutable suggestion information for binding in ref pattern like:  `let &b = a;` )
 - rust-lang#115702 (Update mailmap)
 - rust-lang#115708 (fix homogeneous_aggregate not ignoring some ZST)
 - rust-lang#115739 (Call `LateLintPass::check_attribute` from `with_lint_attrs`)
 - rust-lang#115743 (Point out if a local trait has no implementations)
 - rust-lang#115744 (Improve diagnostic for generic params from outer items (E0401))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors mentioned this pull request Sep 11, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (68c2f5b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-2.6%, -2.4%] 2
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-2.8%, -2.3%] 4
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.551s -> 629.05s (-0.08%)
Artifact size: 317.53 MiB -> 317.65 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
5 participants
@chenyukang @rustbot @davidtwco @bors @rust-timer