Add Pointer Authentication intrinsics #118104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Nov 21, 2023
| ifn!("llvm.ptrauth.strip.i64", fn(t_i64, t_i32) -> t_i64); | ||
| ifn!("llvm.ptrauth.resign.i64", fn(t_i64, t_i32, t_i64, t_i32, t_i64) -> t_i64); | ||
| ifn!("llvm.ptrauth.sign_generic.i64", fn(t_i64, t_i64) -> t_i64); | ||
| ifn!("llvm.ptrauth.blend.i64", fn(t_i64, t_i64) -> t_i64); |
There was a problem hiding this comment.
You only need to add LLVM intrinsics in this place that are actually called by rustc_codegen_llvm.
There was a problem hiding this comment.
@arttet is this comment resolved?
thanks
There was a problem hiding this comment.
My sincere apologies for the delay.
So, I believe I've fixed it, is that correct?
|
r? @bjorn3 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
unsure about that status but I think this is waiting on the author (comment pending a reply?) @rustbot author |
rustbot
added
S-waiting-on-author
apiraino
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pointer Authentication intrinsics. They are related to arm64e architecture.
#115526
#73628