Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #133667

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Remove unused code #133667

merged 1 commit into from
Nov 30, 2024

Conversation

sunwxg
Copy link
Contributor

@sunwxg sunwxg commented Nov 30, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@clubby789
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 30, 2024

📌 Commit 92a1a1d has been approved by clubby789

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 30, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2024
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 30, 2024
@RalfJung
Rollup merge of rust-lang#133667 - sunwxg:xiaoguang/remove-unused-cod…
244bf5f 
…e, r=clubby789

Remove unused code
This was referenced Nov 30, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@bors
Auto merge of rust-lang#133684 - RalfJung:rollup-j2tmrg7, r=RalfJung
7442931 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131698 (use stores of the correct size to set discriminants)
 - rust-lang#133571 (Mark visionOS as supporting `std`)
 - rust-lang#133655 (Eliminate print_expr_maybe_paren function from pretty printers)
 - rust-lang#133667 (Remove unused code)
 - rust-lang#133670 (bump hashbrown version)
 - rust-lang#133673 (replace hard coded error id with `ErrorKind::DirectoryNotEmpty`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 35e92ae into rust-lang:master Nov 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@rust-timer
Unrolled build for rust-lang#133667
49bfd1b 
Rollup merge of rust-lang#133667 - sunwxg:xiaoguang/remove-unused-code, r=clubby789

Remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sunwxg @rustbot @clubby789 @bors @jieyouxu