-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Auto merge of #133654 - weihanglo:update-cargo, r=weihanglo" #133671
Conversation
|
Some changes occurred in src/tools/cargo cc @ehuss |
@bors treeclosed=100 |
r=me if you don't need a t-cargo approval |
Don't think we need t-cargo approval as this is just a revert. @bors r=lqd p=1000 |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
Assuming this will land, let's make sure the queue can proceed immediately. @bors treeclosed- |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e48ddd8): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -5.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 773.805s -> 773.769s (-0.00%) |
This reverts commit 76f3ff6, reversing changes made to 1fc691e.
The new pgo_works test fails when rust is built without profiling support, including in CI on x86_64-gnu-aux. See #133499 (comment) for how this happened.