-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn sufficiently old compatibility lints into hard errors #42136
Conversation
Started crater run:
|
Primary problems are petgraph and typemap, though there are a few others.
Legitimate failures:
False positives:
|
This is interesting, all the affected crates (except for abandoned |
Yeah, this is a common scenario. Frustrating. I'm not sure what's the best fix. Another option is to encourage the crate authors to push a new minor version that fixes the lint; we have done that in the past for major cases. |
☔ The latest upstream changes (presumably #40847) made this pull request unmergeable. Please resolve the merge conflicts. |
cc @rust-lang/compiler @alexcrichton @brson -- so what should we do here? There are a number of outdated dependencies in crater which means that if we "close the door" on these compatibility lints, they will break. One option:
Seems like pinging authors is a good first step! |
I've already submitted PRs to all affected crates except for those depending on |
Thanks for the legwork here sending PRs @petrochenkov! It sounds like the major sources of breakage are or are about to all be mitigated? In that sense maybe leave |
Done. |
@petrochenkov @nikomatsakis Does this need another crater run? The status tag wasn't removed after the last one and I'm not clear on the current status based on discussion. |
@Mark-Simulacrum |
I'm a little confused by that; if we land this now, before the PRs are merged and published, presumably that would still break the ecosystem? Or am I missing something? |
@Mark-Simulacrum |
Ah, okay. Wasn't sure about the actual impact of these changes. |
☔ The latest upstream changes (presumably #41856) made this pull request unmergeable. Please resolve the merge conflicts. |
r=me once rebased |
@petrochenkov for future tracking purposes if you've still got links to the PRs to fix upstream crates, mind throwing them into the PR description? That way if we see regressions crop up on crater we can quickly find the upstream PR to fix it. |
@bors r=nikomatsakis |
📌 Commit 26d5c0e has been approved by |
Turn sufficiently old compatibility lints into hard errors It's been almost 7 months since #36894 was merged, so it's time to take the next step. [breaking-change], needs crater run. PRs/issues submitted to affected crates: https://github.com/alexcrichton/ctest/pull/17 Sean1708/rusty-cheddar#55 m-r-r/helianto#3 azdle/virgil#1 rust-locale/rust-locale#24 mneumann/acyclic-network-rs#1 reem/rust-typemap#38 cc https://internals.rust-lang.org/t/moving-forward-on-forward-compatibility-lints/4204 cc #34537 #36887 Closes #36886 Closes #36888 Closes #36890 Closes #36891 Closes #36892 r? @nikomatsakis
💔 Test failed - status-appveyor |
Error looks potentially spurious, but hard to tell. @bors retry
|
Turn sufficiently old compatibility lints into hard errors It's been almost 7 months since rust-lang#36894 was merged, so it's time to take the next step. [breaking-change], needs crater run. PRs/issues submitted to affected crates: https://github.com/alexcrichton/ctest/pull/17 Sean1708/rusty-cheddar#55 m-r-r/helianto#3 azdle/virgil#1 rust-locale/rust-locale#24 mneumann/acyclic-network-rs#1 reem/rust-typemap#38 cc https://internals.rust-lang.org/t/moving-forward-on-forward-compatibility-lints/4204 cc rust-lang#34537 rust-lang#36887 Closes rust-lang#36886 Closes rust-lang#36888 Closes rust-lang#36890 Closes rust-lang#36891 Closes rust-lang#36892 r? @nikomatsakis
My guess is #33434 |
We're probably going to need writeups of all these for the release notes. |
It's been almost 7 months since #36894 was merged, so it's time to take the next step.
[breaking-change], needs crater run.
PRs/issues submitted to affected crates:
https://github.com/alexcrichton/ctest/pull/17
Sean1708/rusty-cheddar#55
m-r-r/helianto#3
azdle/virgil#1
rust-locale/rust-locale#24
mneumann/acyclic-network-rs#1
reem/rust-typemap#38
cc https://internals.rust-lang.org/t/moving-forward-on-forward-compatibility-lints/4204
cc #34537 #36887
Closes #36886
Closes #36888
Closes #36890
Closes #36891
Closes #36892
r? @nikomatsakis