associated_consts: check trait obligations and regionck for associated consts #42324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
S-waiting-on-crater
|
This needs a crater run - people might have been trying to sneak things. |
|
A crater run? It's an unstable feature, and this fixes a soundness hole, as described in #41323. |
|
I don't think that a crater run is needed for an unstable feature, but it'd be a kindness. |
|
I'm going to kick off a crater run, but I'll r+ in the meantime. |
|
@bors r+ |
|
📌 Commit 62989c1 has been approved by |
nikomatsakis
removed
the
S-waiting-on-crater
|
Missed that this is in an unstable feature. |
aidanhs
added
the
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 1, 2017
…l, r=nikomatsakis associated_consts: check trait obligations and regionck for associated consts Closes rust-lang#41323 r? @nikomatsakis
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 1, 2017
…l, r=nikomatsakis associated_consts: check trait obligations and regionck for associated consts Closes rust-lang#41323 r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41323
r? @nikomatsakis