Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded body class selector #56416

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Remove unneeded body class selector #56416

merged 1 commit into from
Dec 3, 2018

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2018
QuietMisdreavus
QuietMisdreavus approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We need this to make sure the line numbers work on docs.rs.

@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 1, 2018

📌 Commit 08a6cf3 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2018
@Centril Centril mentioned this pull request Dec 1, 2018
Closed
@QuietMisdreavus QuietMisdreavus mentioned this pull request Dec 1, 2018
Closed
Centril added a commit to Centril/rust that referenced this pull request Dec 1, 2018
@Centril
Rollup merge of rust-lang#56416 - GuillaumeGomez:css-body, r=QuietMis…
ba05902 
…dreavus

Remove unneeded body class selector

r? @QuietMisdreavus
@Centril Centril mentioned this pull request Dec 1, 2018
Closed
@Centril Centril mentioned this pull request Dec 2, 2018
Closed
@Centril Centril mentioned this pull request Dec 2, 2018
Closed
@Centril Centril mentioned this pull request Dec 2, 2018
Closed
@Centril Centril mentioned this pull request Dec 2, 2018
Closed
Centril added a commit to Centril/rust that referenced this pull request Dec 2, 2018
@Centril
Rollup merge of rust-lang#56416 - GuillaumeGomez:css-body, r=QuietMis…
298e681 
…dreavus

Remove unneeded body class selector

r? @QuietMisdreavus
@Centril Centril mentioned this pull request Dec 2, 2018
Closed
bors added a commit that referenced this pull request Dec 2, 2018
@bors
Auto merge of #56437 - Centril:rollup, r=Centril
1a8b4e9 
Rollup of 14 pull requests

Successful merges:

 - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks)
 - #56305 (update miri)
 - #56366 (Stabilize self_in_typedefs feature)
 - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs)
 - #56394 (Deal with EINTR in net timeout tests)
 - #56395 (Stabilize dbg!(...))
 - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block)
 - #56402 (Improve the unstable book example for #[marker] trait)
 - #56412 (Update tracking issue for `extern_crate_self`)
 - #56416 (Remove unneeded body class selector)
 - #56418 (Fix failing tidy (line endings on Windows))
 - #56419 (Remove some uses of try!)
 - #56424 (Mention raw-ident syntax)
 - #56432 (Update issue number of `shrink_to` methods to point the tracking issue)

Failed merges:

r? @ghost
kennytm added a commit to kennytm/rust that referenced this pull request Dec 3, 2018
@kennytm
Rollup merge of rust-lang#56416 - GuillaumeGomez:css-body, r=QuietMis…
17f6fc7 
…dreavus

Remove unneeded body class selector

r? @QuietMisdreavus
@kennytm kennytm mentioned this pull request Dec 3, 2018
Merged
bors added a commit that referenced this pull request Dec 3, 2018
@bors
Auto merge of #56451 - kennytm:rollup, r=kennytm
0c999ed 
Rollup of 13 pull requests

Successful merges:

 - #56141 ([std] Osstr len clarity)
 - #56366 (Stabilize self_in_typedefs feature)
 - #56395 (Stabilize dbg!(...))
 - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block)
 - #56402 (Improve the unstable book example for #[marker] trait)
 - #56412 (Update tracking issue for `extern_crate_self`)
 - #56416 (Remove unneeded body class selector)
 - #56418 (Fix failing tidy (line endings on Windows))
 - #56419 (Remove some uses of try!)
 - #56432 (Update issue number of `shrink_to` methods to point the tracking issue)
 - #56433 (Add description about `crate` for parse_visibility's comment)
 - #56435 (make the C part of compiler-builtins opt-out)
 - #56438 (Remove not used `DotEq` token)

Failed merges:

r? @ghost
@bors bors merged commit 08a6cf3 into rust-lang:master Dec 3, 2018
@GuillaumeGomez GuillaumeGomez deleted the css-body branch December 3, 2018 19:04
@talchas
Copy link

talchas commented Dec 4, 2018 •
edited
Loading

This rebroke the display of line numbers again: :not(.source) is not in fact the same as body:not(.source) (I think the simplest solution for both would be .rustdoc:not(.source)).

@GuillaumeGomez
Copy link
Member Author

Indeed. sending a fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus approved these changes

Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @QuietMisdreavus @bors @talchas @rust-highfive