Rollup of 13 pull requests #56451
Merged
Rollup of 13 pull requests #56451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps users to understand capacity related values, which may surpise on Windows. Also is a step towards clarifying understanding of `OsStr`'s len() return value.
The previous one didn't actually use the Display&Debug bounds in any way, so I think this one is a bit more meaningful.
This rule was introduced by rust-lang#45401.
Currently libproc_macro does not use `DotEq` token. rust-lang#49545 changed libproc_macro to not generate `DotEq` token.
[std] Osstr len clarity
… r=Centril Stabilize self_in_typedefs feature [**Tracking Issue**](rust-lang#49303) r? @Centril
…nSapin Stabilize dbg!(...) Per FCP in rust-lang#54306 (which is ~1 day from completion). r? @SimonSapin The PR is fairly isolated so a rollup should probably work.
…olnay Move VecDeque::resize_with out of the impl<T:Clone> block I put this in the wrong `impl` block in rust-lang#56016, so fixing. Tracking issue for the unstable method: rust-lang#41758 (comment)
…e, r=Centril Improve the unstable book example for #[marker] trait The previous one didn't actually use the Display&Debug bounds in any way, so I think this one is a bit more meaningful.
Update tracking issue for `extern_crate_self`
…dreavus Remove unneeded body class selector r? @QuietMisdreavus
Fix failing tidy (line endings on Windows) Updates to `rustc-guide` and `edition-guide` including rust-lang/rustc-dev-guide#246 and rust-lang/edition-guide#122.
Remove some uses of try!
Update issue number of `shrink_to` methods to point the tracking issue Tracking issue: rust-lang#56431
…ibility, r=petrochenkov Add description about `crate` for parse_visibility's comment This rule was introduced by rust-lang#45401.
…ichton make the C part of compiler-builtins opt-out I'd like to be able to use Xargo to build a libstd without having a full C toolchain for the target. This is a start (but the fact that libstd is a dylib is still a problem). However, compiler_builtin already has somewhat similar logic to not require a C compiler for wasm: https://github.com/rust-lang-nursery/compiler-builtins/blob/fe74674f6e4be76d47b66f67d529ebf4186f4eb1/build.rs#L36-L41 (WTF GitHub, why doesn't this show an embedded code preview??) I wonder if there is a way to not have two separate mechanisms? Like, move the above wasm logic to some place that controls the libstd feature, or so? Or is it okay to have these two mechanisms co-exist? Cc @alexcrichton
…, r=petrochenkov Remove not used `DotEq` token Currently libproc_macro does not use `DotEq` token. rust-lang#49545 changed libproc_macro to not generate `DotEq` token.
|
@bors r+ p=13 |
|
📌 Commit ac363d8 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 3, 2018
Rollup of 13 pull requests Successful merges: - #56141 ([std] Osstr len clarity) - #56366 (Stabilize self_in_typedefs feature) - #56395 (Stabilize dbg!(...)) - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block) - #56402 (Improve the unstable book example for #[marker] trait) - #56412 (Update tracking issue for `extern_crate_self`) - #56416 (Remove unneeded body class selector) - #56418 (Fix failing tidy (line endings on Windows)) - #56419 (Remove some uses of try!) - #56432 (Update issue number of `shrink_to` methods to point the tracking issue) - #56433 (Add description about `crate` for parse_visibility's comment) - #56435 (make the C part of compiler-builtins opt-out) - #56438 (Remove not used `DotEq` token) Failed merges: r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
extern_crate_self#56412 (Update tracking issue forextern_crate_self)shrink_tomethods to point the tracking issue #56432 (Update issue number ofshrink_tomethods to point the tracking issue)cratefor parse_visibility's comment #56433 (Add description aboutcratefor parse_visibility's comment)DotEqtoken #56438 (Remove not usedDotEqtoken)Failed merges:
r? @ghost