Cleanup e0374 #69554
Merged
Cleanup e0374 #69554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
cleanup-e0374
branch
from
a70b9d7 to
7856cb8
Compare
JohnTitor
added
the
S-waiting-on-review
Dylan-DPC-zz
suggested changes
Feb 29, 2020
| containing an unsized type is also unsized. | ||
|
|
||
| [1]: https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait | ||
| `CoerceUnsized` was implemented on a struct without a field containing an usized |
There was a problem hiding this comment.
Suggested change
| `CoerceUnsized` was implemented on a struct without a field containing an usized | |
| `CoerceUnsized` was implemented on a struct which does not contain a field with an unsized type |
| @@ -20,6 +16,12 @@ impl<T, U> CoerceUnsized<Foo<U>> for Foo<T> | |||
| where T: CoerceUnsized<U> {} | |||
| ``` | |||
|
|
|||
| An [unsized type][1] is any type that the compiler doesn't know the length or | |||
There was a problem hiding this comment.
Suggested change
| An [unsized type][1] is any type that the compiler doesn't know the length or | |
| An [unsized type][1] is any type where the compiler does not know the length or |
GuillaumeGomez
force-pushed
the
cleanup-e0374
branch
from
7856cb8 to
45053d1
Compare
|
Updated! |
|
@bors r+ rollup |
|
📌 Commit 45053d1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 1, 2020
Rollup of 7 pull requests Successful merges: - #69504 (Use assert_ne in hash tests) - #69554 (Cleanup e0374) - #69568 (Clarify explanation of Vec<T> 'fn resize') - #69569 (simplify boolean expressions) - #69577 (Clean up E0375 explanation) - #69598 (rustdoc: HTML escape crate version) - #69607 (Clean up E0376 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC