Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify explanation of Vec<T> 'fn resize' #69568

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Clarify explanation of Vec<T> 'fn resize' #69568

merged 3 commits into from
Mar 1, 2020

Conversation

JOE1994
Copy link
Contributor

@JOE1994 JOE1994 commented Feb 29, 2020

  1. Clarified on what should implement Clone trait.
  2. Minor grammar fix:
    to be able clone => to be able to clone

@JOE1994
Clarify explanation of 'fn resize'
2ad52cd 
1. Clarified on what should implement 'Clone' trait.
2. Minor grammar fix:
to be able clone => to be able to clone
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 29, 2020
jonas-schievink
jonas-schievink suggested changes Feb 29, 2020
View reviewed changes
src/liballoc/vec.rs Outdated Show resolved Hide resolved
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-02-29T00:32:43.1266641Z ========================== Starting Command Output ===========================
2020-02-29T00:32:43.1269383Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/ff26a12e-5fce-4f96-96a2-451c7e91a7a7.sh
2020-02-29T00:32:43.1269606Z 
2020-02-29T00:32:43.1274299Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-29T00:32:43.1293375Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69568/merge to s
2020-02-29T00:32:43.1296585Z Task         : Get sources
2020-02-29T00:32:43.1296816Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-29T00:32:43.1297041Z Version      : 1.0.0
2020-02-29T00:32:43.1297237Z Author       : Microsoft
---
2020-02-29T00:32:44.4032408Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-29T00:32:44.4038415Z ##[command]git config gc.auto 0
2020-02-29T00:32:44.4041927Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-29T00:32:44.4044771Z ##[command]git config --get-all http.proxy
2020-02-29T00:32:44.4050849Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69568/merge:refs/remotes/pull/69568/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

JOE1994 and others added 2 commits February 29, 2020 00:52
@JOE1994 @jonas-schievink
Update src/liballoc/vec.rs
fb46d2b 
Following suggestion from @jonas-schievink

Co-Authored-By: Jonas Schievink <[email protected]>
@JOE1994
Remove trailing whitespace
6e265c5 
Removed trailing whitespace which caused to fail pretty-check
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 1, 2020

📌 Commit 6e265c5 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2020
@Dylan-DPC-zz
Copy link

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2020
@Dylan-DPC-zz
Copy link

sorry, it is fine :D

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 1, 2020

📌 Commit 6e265c5 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 1, 2020
Merged
bors added a commit that referenced this pull request Mar 1, 2020
@bors
Auto merge of #69612 - Dylan-DPC:rollup-f180gcc, r=Dylan-DPC
beac68a 
Rollup of 7 pull requests

Successful merges:

 - #69504 (Use assert_ne in hash tests)
 - #69554 (Cleanup e0374)
 - #69568 (Clarify explanation of Vec<T> 'fn resize')
 - #69569 (simplify boolean expressions)
 - #69577 (Clean up E0375 explanation)
 - #69598 (rustdoc: HTML escape crate version)
 - #69607 (Clean up E0376 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 55d0a8b into rust-lang:master Mar 1, 2020
@JOE1994 JOE1994 deleted the patch-2 branch March 3, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink requested changes

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JOE1994 @rust-highfive @Dylan-DPC-zz @bors @jonas-schievink @joshtriplett