Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[deny(unsafe_op_in_unsafe_fn)] in sys/cloudabi #75115

Merged
merged 1 commit into from
Oct 25, 2020
Merged

#[deny(unsafe_op_in_unsafe_fn)] in sys/cloudabi #75115

merged 1 commit into from
Oct 25, 2020

Conversation

chansuke
Copy link
Contributor

@chansuke chansuke commented Aug 3, 2020

Partial fix of #73904.

This encloses unsafe operations in unsafe fn in sys/cloudabi.

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2020
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request Aug 3, 2020
Closed
22 tasks
@KodrAus
Copy link
Contributor

KodrAus commented Aug 4, 2020

Thanks @chansuke!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 4, 2020

📌 Commit 6d8277b36e2a0da62108414617dd6963cfb33e3f has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit 6d8277b36e2a0da62108414617dd6963cfb33e3f with merge 4a1eeda026c9978fd5dbaa43f5b65482238d17b2...

@bors
Copy link
Contributor

bors commented Aug 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2020
@JohnTitor JohnTitor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@chansuke chansuke force-pushed the sys-cloudabi-unsafe branch from 6d8277b to cd5654e Compare August 8, 2020 23:56
JohnTitor
JohnTitor approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine now. @KodrAus could you take another look?

@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2020
@KodrAus
Copy link
Contributor

KodrAus commented Aug 12, 2020

Alrighty, let's try run this one through again.

@bors r+

@bors
Copy link
Contributor

bors commented Aug 12, 2020

📌 Commit cd5654e has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#75115 - chansuke:sys-cloudabi-unsafe, r=Kod…
29f508e 
…rAus

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi

Partial fix of rust-lang#73904.

This encloses unsafe operations in unsafe fn in sys/cloudabi.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Aug 13, 2020
Closed
@bors
Copy link
Contributor

bors commented Aug 13, 2020

⌛ Testing commit cd5654e with merge d5ea4bcea627275d51acff7cf6006be44f926e38...

@bors
Copy link
Contributor

bors commented Aug 13, 2020

💔 Test failed - checks-actions

@crlf0710
Copy link
Member

@chansuke Ping from triage, it seems there's a compilation error. Since this platform is not covered by default in pr builds, consider test building it locally. (or temporarily tweak ci configuration to test it.) Thanks!

@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2020
@chansuke
Copy link
Contributor Author

@crlf0710 Thanks, I'll take a look at the compilation error.

@crlf0710
Copy link
Member

@chansuke Ping from triage, any updates on this?

@chansuke
Copy link
Contributor Author

chansuke commented Oct 4, 2020

@crlf0710 Sorry, no progress on this issue...

@chansuke chansuke force-pushed the sys-cloudabi-unsafe branch from cd5654e to 8b6caf0 Compare October 10, 2020 12:21
@chansuke
Copy link
Contributor Author

@crlf0710 I fixed the compilation error, thanks.

@bors
Copy link
Contributor

bors commented Oct 16, 2020

☔ The latest upstream changes (presumably #78001) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@chansuke chansuke force-pushed the sys-cloudabi-unsafe branch 2 times, most recently from b17b9e3 to c1d8895 Compare October 18, 2020 08:37
@chansuke chansuke force-pushed the sys-cloudabi-unsafe branch from c1d8895 to d3467fe Compare October 18, 2020 09:00
@chansuke
Copy link
Contributor Author

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2020
@KodrAus
Copy link
Contributor

KodrAus commented Oct 23, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2020

📌 Commit d3467fe has been approved by KodrAus

@bors
Copy link
Contributor

bors commented Oct 23, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 23, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Oct 23, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Oct 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2020
@bors
Auto merge of rust-lang#78334 - jonas-schievink:rollup-z0gzbmm, r=jon…
f58ffc9 
…as-schievink

Rollup of 12 pull requests

Successful merges:

 - rust-lang#75115 (`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi)
 - rust-lang#76614 (change the order of type arguments on ControlFlow)
 - rust-lang#77610 (revise Hermit's mutex interface to support the behaviour of StaticMutex)
 - rust-lang#77830 (Simplify query proc-macros)
 - rust-lang#77930 (Do not ICE with TraitPredicates containing [type error])
 - rust-lang#78069 (Fix const core::panic!(non_literal_str).)
 - rust-lang#78072 (Cleanup constant matching in exhaustiveness checking)
 - rust-lang#78119 (Throw core::panic!("message") as &str instead of String.)
 - rust-lang#78191 (Introduce a temporary for discriminant value in MatchBranchSimplification)
 - rust-lang#78272 (const_evaluatable_checked: deal with unused nodes + div)
 - rust-lang#78318 (TyCtxt: generate single impl block with `slice_interners` macro)
 - rust-lang#78327 (resolve: Relax macro resolution consistency check to account for any errors)

Failed merges:

r? `@ghost`
@bors bors merged commit 01a38f0 into rust-lang:master Oct 25, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@KodrAus KodrAus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
7 participants
@chansuke @rust-highfive @KodrAus @bors @crlf0710 @JohnTitor @rustbot