Fix ICE with ReadPointerAsBytes validation error
#80900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-const-eval
rust-highfive
added
the
S-waiting-on-review
camelid
commented
Jan 11, 2021
| --> $DIR/issue-79690.rs:26:1 | ||
| | | ||
| LL | const G: Fat = unsafe { Transmute { t: FOO }.u }; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered read of part of a pointer at .1.<deref>.size.foo |
There was a problem hiding this comment.
This error message doesn't seem super clear to me. In fact, I'm not sure if I understand it! Will it be understandable to people getting this error, or can it be improved somehow?
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Huh, I guess this test made us reach tidy's limit! What should I do? |
I guess you're the first case? 😄 You could move it to |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Um... that's really weird: I moved the test and the error message changed: ---- [ui] ui/consts/issue-79690.rs stdout ----
diff of stderr:
2 --> $DIR/issue-79690.rs:26:1
3 |
4 LL | const G: Fat = unsafe { Transmute { t: FOO }.u };
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered read of part of a pointer at .1.<deref>.size.foo
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered pointer to alloc4 at .1.<deref>.size.foo, but expected initialized plain (non-pointer) bytes
6 |
7 = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
8 |
|
That's super odd. I don't think it can be the move, maybe something changed on master under you? Try rebasing and reblessing. |
camelid
added
the
S-waiting-on-author
Apparently `tidy` has a hard limit of 2830 tests in the `src/test/ui/issues/` directory, and this test hit that limit. `src/test/ui/consts/` is probably a better location anyway.
camelid
force-pushed
the
readpointerasbytes-ice
branch
from
3c1dd4d to
a7b7a43
Compare
|
Rebased. Rerunning test locally. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Huh, the test passed locally but not on CI... |
camelid
removed
the
S-waiting-on-author
@oli-obk I rebased and ran the test locally, and it passed. But, it's still failing on CI.
So, I'm not sure what's going on. Maybe we should get someone from T-infra to take a look at it? |
|
The one thought I have is that maybe this is some kind of platform-specific code in the compiler that's being executed (I'm on macOS and CI is Linux, so it's different platforms), but I don't see why this compiler code should be platform-specific since it's MIR-based. |
|
Aaah... I found the issue. CI is testing on 32 bit. So just ignore the test on 32 bit, it's not worth supporting that case in this specific test. |
Done! |
|
@bors squash |
|
(I think |
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
readpointerasbytes-ice
branch
from
9b2aca1 to
2be1993
Compare
|
@bors r+ rollup 🤷 it's fine by me |
|
📌 Commit 2be1993 has been approved by |
bors
added
S-waiting-on-bors
This was referenced Jan 25, 2021
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 26, 2021
…li-obk Fix ICE with `ReadPointerAsBytes` validation error Fixes rust-lang#79690. r? `````@oli-obk`````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2021
Rollup of 14 pull requests Successful merges: - rust-lang#80812 (Update RELEASES.md for 1.50.0) - rust-lang#80876 (Add `unwrap_unchecked()` methods for `Option` and `Result`) - rust-lang#80900 (Fix ICE with `ReadPointerAsBytes` validation error) - rust-lang#81191 (BTreeMap: test all borrowing interfaces and test more chaotic order behavior) - rust-lang#81195 (Account for generics when suggesting bound) - rust-lang#81299 (Fix some bugs reported by eslint) - rust-lang#81325 (typeck: Don't suggest converting LHS exprs) - rust-lang#81353 (Fix spelling in documentation for error E0207) - rust-lang#81369 (rustc_codegen_ssa: use wall time for codegen_to_LLVM_IR time-passes entry) - rust-lang#81389 (rustdoc: Document CommonMark extensions.) - rust-lang#81399 (Update books) - rust-lang#81401 (tidy: Some code cleanup.) - rust-lang#81407 (Refine "remove semicolon" suggestion in trait selection) - rust-lang#81412 (Fix assertion in `MaybeUninit::array_assume_init()` for zero-length arrays) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79690.
r? @oli-obk