Account for generics when suggesting bound #81195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Jan 20, 2021
|
r? @oli-obk |
estebank
added
the
A-suggestion-diagnostics
estebank
force-pushed
the
suggest-bound-on-trait-with-params
branch
from
5998005 to
088c89d
Compare
|
@bors r+ rollup |
|
📌 Commit 088c89d has been approved by |
bors
added
S-waiting-on-bors
This was referenced Jan 25, 2021
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 26, 2021
…h-params, r=oli-obk Account for generics when suggesting bound Fix rust-lang#81175.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2021
Rollup of 14 pull requests Successful merges: - rust-lang#80812 (Update RELEASES.md for 1.50.0) - rust-lang#80876 (Add `unwrap_unchecked()` methods for `Option` and `Result`) - rust-lang#80900 (Fix ICE with `ReadPointerAsBytes` validation error) - rust-lang#81191 (BTreeMap: test all borrowing interfaces and test more chaotic order behavior) - rust-lang#81195 (Account for generics when suggesting bound) - rust-lang#81299 (Fix some bugs reported by eslint) - rust-lang#81325 (typeck: Don't suggest converting LHS exprs) - rust-lang#81353 (Fix spelling in documentation for error E0207) - rust-lang#81369 (rustc_codegen_ssa: use wall time for codegen_to_LLVM_IR time-passes entry) - rust-lang#81389 (rustdoc: Document CommonMark extensions.) - rust-lang#81399 (Update books) - rust-lang#81401 (tidy: Some code cleanup.) - rust-lang#81407 (Refine "remove semicolon" suggestion in trait selection) - rust-lang#81412 (Fix assertion in `MaybeUninit::array_assume_init()` for zero-length arrays) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #81175.