-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpret: remove MemoryExtra in favor of giving access to the Machine #95620
Conversation
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these changes make it very clear that this is the right way forward imo.
I still want to look over the miri changes though I don't expect anything deal breaking
fc572c7
to
84a343d
Compare
@bors r+ |
📌 Commit 84a343d has been approved by |
interpret: remove MemoryExtra in favor of giving access to the Machine The Miri PR for this is upcoming. r? `@oli-obk`
Rollup of 7 pull requests Successful merges: - rust-lang#91873 (Mention implementers of unsatisfied trait) - rust-lang#95588 (explicitly distinguish pointer::addr and pointer::expose_addr) - rust-lang#95603 (Fix late-bound ICE in `dyn` return type suggestion) - rust-lang#95620 (interpret: remove MemoryExtra in favor of giving access to the Machine) - rust-lang#95630 (Update `NonNull` pointer provenance methods' documentation) - rust-lang#95631 (Refactor: remove unnecessary nested blocks) - rust-lang#95642 (`CandidateSource::XCandidate` -> `CandidateSource::X`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
adjust for MemoryExtra being merged into Machine The Miri side of rust-lang/rust#95620
The Miri PR for this is upcoming.
r? @oli-obk