Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NonNull pointer provenance methods' documentation #95630

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Update NonNull pointer provenance methods' documentation #95630

merged 1 commit into from
Apr 5, 2022

Conversation

declanvk
Copy link
Contributor

@declanvk declanvk commented Apr 4, 2022

  • Add links to equivalent methods on raw pointers

@rust-highfive
Copy link
Collaborator

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2022
@declanvk
Copy link
Contributor Author

declanvk commented Apr 4, 2022

cc @RalfJung from earlier comment

@RalfJung
Copy link
Member

RalfJung commented Apr 4, 2022

r? @RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned scottmcm Apr 4, 2022
@RalfJung
Copy link
Member

RalfJung commented Apr 4, 2022

Thanks. :)
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 4, 2022

📌 Commit 637592d has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 4, 2022
@Dylan-DPC
Rollup merge of rust-lang#95630 - declanvk:update-nonnull-doc, r=Ralf…
b70f0f6 
…Jung

Update `NonNull` pointer provenance methods' documentation

 - Add links to equivalent methods on raw pointers
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 4, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2022
@bors
Auto merge of rust-lang#95662 - Dylan-DPC:rollup-fo7jsr6, r=Dylan-DPC
a22cf2a 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#91873 (Mention implementers of unsatisfied trait)
 - rust-lang#95588 (explicitly distinguish pointer::addr and pointer::expose_addr)
 - rust-lang#95603 (Fix late-bound ICE in `dyn` return type suggestion)
 - rust-lang#95620 (interpret: remove MemoryExtra in favor of giving access to the Machine)
 - rust-lang#95630 (Update `NonNull` pointer provenance methods' documentation)
 - rust-lang#95631 (Refactor: remove unnecessary nested blocks)
 - rust-lang#95642 (`CandidateSource::XCandidate` -> `CandidateSource::X`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1c2b4b7 into rust-lang:master Apr 5, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 5, 2022
@declanvk declanvk deleted the update-nonnull-doc branch April 5, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@declanvk @rust-highfive @RalfJung @bors @scottmcm @rustbot