-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bootstrap] Give a better error when trying to run a path with no registered step #96660
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
…istered step Before: ``` thread 'main' panicked at 'error: no rules matched invalid', src/bootstrap/builder.rs:287:17 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` After: ``` error: no `check` rules matched 'invalid' help: run `x.py check --help --verbose` to show a list of available paths note: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!` ```
f77a48b
to
3a800bf
Compare
builder.kind.as_str() | ||
); | ||
eprintln!( | ||
"note: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think probably we should say something like "in src/bootstrap/builder.rs" here, though I guess it's not that hard to find:
$ rg 'describe!'
src/bootstrap/builder.rs
494: Kind::Build => describe!(
525: Kind::Check => describe!(
536: Kind::Test => describe!(
591: Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
592: Kind::Doc => describe!(
612: Kind::Dist => describe!(
640: Kind::Install => describe!(
654: Kind::Run => describe!(run::ExpandYamlAnchors, run::BuildManifest, run::BumpStage0),
So maybe alright for now, and better short for such a specific message anyway.
@bors r+ rollup |
📌 Commit 3a800bf has been approved by |
…piler-errors Rollup of 8 pull requests Successful merges: - rust-lang#96660 ([bootstrap] Give a better error when trying to run a path with no registered step) - rust-lang#96701 (update `jemallocator` example to use 2018 edition import syntax) - rust-lang#96746 (Fix an ICE on rust-lang#96738) - rust-lang#96758 (bootstrap: bsd platform flags for split debuginfo) - rust-lang#96778 (Remove closures on `expect_local` to apply `#[track_caller]`) - rust-lang#96781 (Fix an incorrect link in The Unstable Book) - rust-lang#96783 (Link to correct issue in issue-95034 known-bug) - rust-lang#96801 (Add regression test for rust-lang#96319) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Before:
After: