Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Remove ItemFragment(Kind) #97066

Merged
merged 3 commits into from
May 27, 2022
Merged

rustdoc: Remove ItemFragment(Kind) #97066

merged 3 commits into from
May 27, 2022

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented May 15, 2022 •
edited
Loading

And stop using write! when rendering URL fragments to avoid impossible errors.

@rust-highfive
Copy link
Collaborator

Some changes occurred in clean/types.rs.

cc @camelid

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 15, 2022
@rust-highfive
Copy link
Collaborator

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2022
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2022
@bors
Copy link
Contributor

bors commented May 15, 2022

⌛ Trying commit c3a5401ec6b077cfd909e391a027426738bad941 with merge 3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e...

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2022
@bors
Copy link
Contributor

bors commented May 16, 2022

☀️ Try build successful - checks-actions
Build commit: 3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e (3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e)

@rust-timer
Copy link
Collaborator

Queued 3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e with parent 29e972d, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3ab18b9418721eebb1f14d8e9f2ae3ecdb85f27e): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 16, 2022
@petrochenkov
Copy link
Contributor Author

I need to think about what should be cached here and what should not.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2022
@jsha
Copy link
Contributor

jsha commented May 16, 2022

@camelid are you available to review this one? It looks like it's related to stuff you've worked on recently.

camelid
camelid reviewed May 20, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall. I think you mentioned you need to investigate the caching some more?

src/librustdoc/passes/collect_intra_doc_links.rs Show resolved Hide resolved
src/librustdoc/passes/collect_intra_doc_links.rs Show resolved Hide resolved
@camelid camelid assigned camelid and unassigned jsha May 20, 2022
@petrochenkov
Copy link
Contributor Author

I think you mentioned you need to investigate the caching some more?

Yes, maybe not for the UrlFragment rendering stuff, because it doesn't affect performance, but for the extra_fragment stuff because it may affect deduplication of the produced errors.

@petrochenkov
Copy link
Contributor Author

I've removed changes that could affect error deduplication.
@rustbot ready

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 21, 2022
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2022
@camelid
Copy link
Member

camelid commented May 26, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 26, 2022

📌 Commit 3f21c31 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2022
@camelid
Copy link
Member

camelid commented May 26, 2022

Might affect perf. @bors rollup=never

@camelid
Copy link
Member

camelid commented May 26, 2022

Oops, I forgot there was already a perf run that showed no changes. @bors rollup

@compiler-errors compiler-errors mentioned this pull request May 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2022
@bors
Auto merge of rust-lang#97444 - compiler-errors:rollup-2gvdav6, r=com…
9a42c65 
…piler-errors

Rollup of 3 pull requests

Successful merges:

 - rust-lang#96051 (Use rounding in float to Duration conversion methods)
 - rust-lang#97066 (rustdoc: Remove `ItemFragment(Kind)`)
 - rust-lang#97436 (Update `triagebot.toml` for macos ping group)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8eb4fc6 into rust-lang:master May 27, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
7 participants
@petrochenkov @rust-highfive @rust-timer @bors @jsha @camelid @rustbot