Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #97444

Merged
merged 13 commits into from
May 27, 2022
Merged

Rollup of 3 pull requests #97444

merged 13 commits into from
May 27, 2022

Conversation

compiler-errors
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

newpavlov and others added 13 commits April 14, 2022 20:44
@newpavlov
Use rounding in float to Duration conversion methods
65c75b2
@petrochenkov
rustdoc: Remove ItemFragment(Kind)
f7521db
@petrochenkov
rustdoc: Stop using write! in UrlFragment::render
c5449f5
@petrochenkov
rustdoc: Some link resolution caching cleanup
3f21c31
@newpavlov
implement tie to even
c2d8445
@newpavlov
tweak doctests
26f8594
@compiler-errors
Update triagebot.toml for macos ping group
c838129
@newpavlov
add debug asserts
06af3a6
@newpavlov
fix nanos overflow for f64
38609cd
@newpavlov
fmt
6495963
@compiler-errors
Rollup merge of rust-lang#96051 - newpavlov:duration_rounding, r=nagi…
e3813e4 
…sa,joshtriplett

Use rounding in float to Duration conversion methods

Closes rust-lang#96045
@compiler-errors
Rollup merge of rust-lang#97066 - petrochenkov:nofragkind, r=camelid
8eb4fc6 
rustdoc: Remove `ItemFragment(Kind)`

And stop using `write!` when rendering URL fragments to avoid impossible errors.
@compiler-errors
Rollup merge of rust-lang#97436 - compiler-errors:macos-ping-2, r=Mar…
036f62b 
…k-Simulacrum

Update `triagebot.toml` for macos ping group

idk what i'm doing but i saw rust-lang#96392 (comment)

cc: `@thomcc`
@rustbot rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 27, 2022
@compiler-errors
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented May 27, 2022

📌 Commit 036f62b has been approved by compiler-errors

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 27, 2022
@bors
Copy link
Contributor

bors commented May 27, 2022

⌛ Testing commit 036f62b with merge 9a42c65...

@bors
Copy link
Contributor

bors commented May 27, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 9a42c65 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 27, 2022
@bors bors merged commit 9a42c65 into rust-lang:master May 27, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 27, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9a42c65): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.6% 1.6% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.5% -3.4% 3
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.4% -2.4% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.4% -2.4% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@compiler-errors compiler-errors deleted the rollup-2gvdav6 branch August 11, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @bors @rust-timer @rustbot @newpavlov @petrochenkov