Omit stdarch workspace from rust-src #97228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path `library/stdarch/crates/Cargo.toml` does not exist. This was introduced in rust-lang#94907.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Ah, should probably have filed this as a stable-to-stable regression, though it's likely to be very low impact I suspect. |
|
r? @bjorn3 |
|
@bors r+ |
|
📌 Commit 8812603 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#97144 (Fix rusty grammar in `std::error::Reporter` docs) - rust-lang#97225 (Fix `Display` for `cell::{Ref,RefMut}`) - rust-lang#97228 (Omit stdarch workspace from rust-src) - rust-lang#97236 (Recover when resolution did not resolve lifetimes.) - rust-lang#97245 (Fix typo in futex RwLock::write_contended.) - rust-lang#97259 (Fix typo in Mir phase docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path
library/stdarch/crates/Cargo.tomldoes not exist.In Rust 1.61.0,
rust-srcstill includessrc/rust/library/stdarch/Cargo.toml(but notstdarch-verify), which includesThis didn't show up when testing with
-Zbuild-stdin #94907 since the standard list of crates to include when buildingstddoes not includestdarch, but it will show up if a user explicitly requestsstdarch. Or, perhaps more importantly, because of #95736, many editors (like IntelliJ) won't treat the root ofrust-srcas a workspace, and will instead recurse into all the sub-crates directly, which then includesstdarch.Also related to #94906.