Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover when resolution did not resolve lifetimes. #97236

Merged
merged 1 commit into from
May 22, 2022

Conversation

cjgillot
Copy link
Contributor

This can happen for items inside a foreign fn's body, which are not visited at all.

Fixes #97193
Fixes #97194

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 20, 2022
@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2022
@rust-log-analyzer

This comment has been minimized.

@cjgillot cjgillot force-pushed the recover-lifetime-res branch from 097266f to 075429f Compare May 21, 2022 07:39
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 21, 2022

📌 Commit 075429f has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#97144 (Fix rusty grammar in `std::error::Reporter` docs)
 - rust-lang#97225 (Fix `Display` for `cell::{Ref,RefMut}`)
 - rust-lang#97228 (Omit stdarch workspace from rust-src)
 - rust-lang#97236 (Recover when resolution did not resolve lifetimes.)
 - rust-lang#97245 (Fix typo in futex RwLock::write_contended.)
 - rust-lang#97259 (Fix typo in Mir phase docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6ef4911 into rust-lang:master May 22, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 22, 2022
@cjgillot cjgillot deleted the recover-lifetime-res branch May 22, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: missing resolution lifetime ICE: 'explicit panic', compiler/rustc_ast_lowering/src/lib.rs:1173:
6 participants