Fix misspelling of "constraint" as "contraint" #98113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -982,7 +982,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> { | |||
| } | |||
| } | |||
|
|
|||
| fn assoc_ty_contraint_param_error_emit(&self, data: &ParenthesizedArgs) -> () { | |||
| fn assoc_ty_constraint_param_error_emit(&self, data: &ParenthesizedArgs) -> () { | |||
There was a problem hiding this comment.
Could you rename this to something starting with emit_? Perhaps emit_bad_parenthesized_trait_in_assoc_ty? It's more consistent with other functions that emit errors.
Also, please remove the -> (), because those are redundant.
EdwinRy
force-pushed
the
constraint-misspelling
branch
from
a644feb to
c8b411e
Compare
|
@bors r+ rollup |
|
📌 Commit c8b411e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#97822 (Filter out intrinsics if we have other import candidates to suggest) - rust-lang#98026 (Move some tests to more reasonable directories) - rust-lang#98067 (compiler: remove unused deps) - rust-lang#98078 (Use unchecked mul to compute slice sizes) - rust-lang#98083 (Rename rustc_serialize::opaque::Encoder as MemEncoder.) - rust-lang#98087 (Suggest adding a `#[macro_export]` to a private macro) - rust-lang#98113 (Fix misspelling of "constraint" as "contraint") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misspelled a function name a while back