Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cleanup crew #556

Merged
merged 7 commits into from
Jan 23, 2020
Merged

add cleanup crew #556

merged 7 commits into from
Jan 23, 2020

Conversation

nikomatsakis
Copy link
Contributor

First draft of describing the "cleanup crew" ICE-breakers team.

src/ice-breaker/cleanup-crew.md Outdated Show resolved Hide resolved
@nikomatsakis
Copy link
Contributor Author

OK, I pushed some basic advice about cargo-bisect-rustc. I'd like to push some advice about finding the set of PRs in a nightly, but I'm actually not sure the best way to do that.

@pnkfelix
Copy link
Member

OK, I pushed some basic advice about cargo-bisect-rustc. I'd like to push some advice about finding the set of PRs in a nightly, but I'm actually not sure the best way to do that.

The biggest problem here is that if you want to do something like git log --author=bors --format=oneline COMMIT1..COMMIT2, you need a local checkout, right? Because I would agree with that, and is a further argument for investing effort in resolving rust-lang/cargo-bisect-rustc#40

(I'm not sure if you find the above git log invocation awkward; it seems pretty stream-lined to me.)

@nikomatsakis
Copy link
Contributor Author

Yes, the biggest problem is probably needing a local checkout -- but I also think we could get more streadmlined. My ideal would be something that extracts and prints markdown with a list of PR numbers

* "blah blah blah", PR #123 by @so-and-so

@pnkfelix pnkfelix self-assigned this Jan 16, 2020
@nikomatsakis nikomatsakis changed the title [WIP] add cleanup crew add cleanup crew Jan 16, 2020
@spastorino
Copy link
Member

@nikomatsakis this is great, left a comment about the last section.

@spastorino
Copy link
Member

spastorino commented Jan 23, 2020

Looks good to me now, maybe as @lqd mentioned in one case, we could provide links for all the streams that show up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants