Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add -WindowsCompatibleOnly switch parameter to install.ps1 #841

Conversation

ev-dev
Copy link
Contributor

@ev-dev ev-dev commented Jun 2, 2022

Description

Introduces a -WindowsCompatibleOnly switch parameter to the existing install.ps1 PowerShell script to allow a user to specify the installation to only include font files labeled as "Windows Compatible" (as in the font file name contains the explicit string "Windows Compatible").

Requirements / Checklist

What does this Pull Request (PR) do?

Implements -WindowsCompatibleOnly parameter for install.ps1 and includes example within the help comments in same file

How should this be manually tested?

On a clean Windows machine (no nerd-fonts installed), invoke PS> .\install.ps1 FiraCode -WindowsCompatibleOnly with/without -WhatIf parameter

What are the relevant tickets (if any)?

Closes #840

@Finii
Copy link
Collaborator

Finii commented Jul 7, 2022

Shouldn't it anyhow install just the 'normal' set XOR the 'windows compat' set?

I install fonts manually, and I choose only one set, always. Are there reasons to have both sets?

And then, what I always wonder (I'm no Windows user), are there still (relevant) applications on Windows that have these ages-old restrictions on font names, that we need the special truncated names at all? I test the fonts usually on a Windows 10 box, and use VisualStudio and LibreOfficeWriter, and they have no problems with the non-Win-Compat fonts. You obviously want only the compat fonts, so maybe you can enlighten me which application needs them?

@Finii
Copy link
Collaborator

Finii commented Sep 24, 2022

I guess this is ok for the time being.

In principle I despise the 'special' Windows Compatible fonts, as they are not really 'special' and double the number of fonts.
I'd rather produce fonts that are universally useful. So maybe they will be dropped some time in the future.

But until that happens...

@Finii Finii force-pushed the feature/ps-install-add-windowscompatibleonly-param branch from 5d1f56a to d9e9d0f Compare September 24, 2022 09:52
@Finii
Copy link
Collaborator

Finii commented Sep 24, 2022

Fix whitespace errors, force push.

@Finii Finii force-pushed the feature/ps-install-add-windowscompatibleonly-param branch from d9e9d0f to 1a9f5e1 Compare September 24, 2022 09:55
@Finii
Copy link
Collaborator

Finii commented Sep 24, 2022

Add Fixes into commit message to enable back-links. Force push (sorry)

@Finii Finii merged commit 539eb92 into ryanoasis:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add parameter to powershell install script to filter for only Windows Compatible fonts
2 participants