Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude more files in production #57

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Exclude more files in production #57

merged 1 commit into from
Mar 15, 2018

Conversation

vinkla
Copy link
Contributor

@vinkla vinkla commented Mar 15, 2018

This pull request excludes even more files which we don't need in production.

https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production/

This pull request excludes even more files which we don't need in production.
@staabm staabm merged commit a713cbd into sabre-io:master Mar 15, 2018
@staabm
Copy link
Member

staabm commented Mar 15, 2018

Thx

@DominikTo
Copy link
Member

Should we really do this?
See discussion here: sabre-io/uri#29

@staabm
Copy link
Member

staabm commented Mar 16, 2018

IMO deleting things like tests/ folder is very valuable, since those can contain security vulnerabilities and produce unnecessary long deployment cycles and download/upload/install times.

since all those information is still present while development I dont see a reason to keep them.

I dont have a strong opinion on this few files which were deleted with this particular PR though.

@DominikTo is it a particular file which you want not to be git-ignored, or is your point more generell?

@vinkla
Copy link
Contributor Author

vinkla commented Mar 16, 2018

One thing that is almost never discussed is moving data on the web and what that costs the environment. A few kilobytes downloaded once is nothing but if you put all downloads together it becomes quite a large amount of data transfered.

Therefore you need 2.04 kg of coal to download 1 mb of data if your internet speed is 1mb per minute - Ankit Kumar

@DominikTo
Copy link
Member

My point is more general. As mentioned in sabre-io/uri#29 - I don't have a strong opinion on this, but there seem to be legitimate drawbacks and little to gain.

See e.g.:

@staabm
Copy link
Member

staabm commented Mar 16, 2018

@DominikTo in my personal experience I had problem with long lasting deployments and security vulnerabilities because of test-mocks therefore I have good reasons (or at least have examples from personal experience) to leave thoses things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants